Added dry run client for running uploads in dry run mode. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
approved these changes
Mar 20, 2025
seanses
requested changes
Mar 21, 2025
There was a problem hiding this comment.
The xtool actually wants to obtain the precise number of bytes a client needs to transfer, this includes the additional bytes to represent the xorb format and counts in the effect of compression. In old remote_client.rs this is implemented by just skipping the reqwest_client.put. The put() in DryRunClient returns Ok(0) and is not sufficient.
|
Given that comment, I think we can actually just drop this pr in favor of 3317388; is that correct? |
|
Dropping; incorporated changes needed into PR 199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a DryRunClient that wraps a given client, but swallows all uploads. This enables dry run mode in the cleaning path simplification PR.