fix uninitialized subset loading #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
approved these changes
Mar 26, 2025
|
Should we only implement this behavior when concat_dataset is set to true in the config? |
|
could be - but imo this is a sane default |
|
we would rather want it to not error out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the concat option, users will often want to run models one after the other (to test different prompts, approaches, etc), without having to regenerate everything or use a new split.
This is why the concat option exists. However, right now, on the first run, the
concat_if_existsoption will fail, because that particular config doesn't exist. Therefore, we handle this, by specifically looking for the issue, where the dataset itself exists, but the split doesn't yet exist (on the first run)