1. modify sourceMap regExp 2.dont't edit source map - #42
Open
yeatszhang wants to merge 2 commits into
Open
Conversation
added 2 commits
November 17, 2015 17:45
2. do not need to modify generated sourceMap
Collaborator
|
LGTM, granted I'm not familiar with sourcemap. Ping @hughsk, can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I use uglifyify writing a browserify plugin.
It do not work.
I found the problem is the source map browserify generated has a chartset field so
matchedisnullsourceMappingURL=data:application\/json;charset:utf-8;base64.I modified the RegExp but it still do not work.
After reading the uglifyjs api, I though it is no need to add these code
I removed these code and it works well. 囧