Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TokenSecretAnnotations for HumioIngestToken #935

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

bsocaciu
Copy link
Contributor

@bsocaciu bsocaciu commented Mar 5, 2025

No description provided.

@bsocaciu bsocaciu requested a review from a team as a code owner March 5, 2025 15:19
Copy link
Member

@SaaldjorMike SaaldjorMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this only works for new secrets. It should also update existing secrets with these annotations. People may start using this feature for existing secrets, or need to change the annotations they use.

@SaaldjorMike SaaldjorMike linked an issue Mar 10, 2025 that may be closed by this pull request
@bsocaciu bsocaciu requested a review from SaaldjorMike March 24, 2025 11:37
@bsocaciu bsocaciu merged commit b66b69b into master Mar 26, 2025
24 checks passed
@bsocaciu bsocaciu deleted the feature/token-secret-annotation-support branch March 26, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TokenSecretAnnotations for HumioIngestToken CRD
2 participants