Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): support bedrock's new converse api #9

Merged

Conversation

bstncartwright
Copy link
Contributor

@bstncartwright bstncartwright commented Jun 13, 2024

This PR enhances the chatmodel/bedrock support to use the new Converse API from Amazon Bedrock. This API provides an abstract interface around the chat functions so that nothing specific has to be done for any model.

I also added some examples around the chatmodel for bedrock.

Fixes #8

@hupe1980 hupe1980 self-requested a review June 14, 2024 05:36
Copy link
Owner

@hupe1980 hupe1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx

@hupe1980 hupe1980 merged commit 93fc636 into hupe1980:main Jun 14, 2024
1 check failed
@bstncartwright bstncartwright deleted the feat/bedrock-chatmodel-converse branch June 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chatmodel Bedrock supports only Meta and Amazon models
2 participants