Skip to content

A11y fixes#23

Open
nihonjinrxs wants to merge 2 commits intomasterfrom
a11y-fixes
Open

A11y fixes#23
nihonjinrxs wants to merge 2 commits intomasterfrom
a11y-fixes

Conversation

@nihonjinrxs
Copy link
Copy Markdown
Member

Description

Resolves #21, resolves #22

This PR fixes link color contrast ratio issues and resolves the semantic HTML issue in the Active Responses list where anchor link tags are direct children of an unordered list tag, rather than list item tags.

Validated with Chrome DevTools Lighthouse Accessibility Audit -- now scores at 100%.

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • This code is tested.
  • I want my code added to the response theme.

@nihonjinrxs nihonjinrxs self-assigned this Sep 16, 2019
@nihonjinrxs nihonjinrxs added the a11y Accessibility-related issues label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Active responses list doesn't follow accessible ul > li format Color contrast ratio issues for links

1 participant