Fix exception handling when messages are null#23
Open
ssb22 wants to merge 1 commit into
Open
Conversation
… JDK 24 ("it's insane right?")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #21 against the modern repository. It changes the code to avoid relying on
getMessage()when reporting exceptions, sincegetMessage()can returnnulland users find"null"in error messages to be uninformative as shown by issue #18.The default
toString()method itself callsgetMessage()and, if it'snull, at least returns the class name of the exception, which is better than just"null". Moreover,toString()is called implicitly if we pass a non-String object toprintlnor add it to a string.While I was at it, I changed a potential null dereference in an exception handler (use
"Help".equals(message)notmessage.equals("Help")because the latter could crash ifmessageis null), and I also cleared the "executable" bit from the permissions of obviously non-executable source files.