refactor: resolve reported VPTO codecheck findings - #1355
Draft
HecreReed wants to merge 5 commits into
Draft
Conversation
HecreReed
marked this pull request as ready for review
August 26, 2026 08:38
HecreReed
marked this pull request as draft
August 26, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- simplify
materializeMemRefViewby moving tile-specific type construction to its caller\n- add braces to the control flow reported inVPTOCANN900LLVMEmitter.cpp\n- replace the reportedgetSaccesses with generic result/operand accessors\n- remove the file-wide-Woverloaded-virtualsuppression\n- reduce Mad and VCVT callee-selection complexity with contract tables\n- table-drive load distribution immediate parsing and share checked shifted-field packing\n- hoist VCVT contracts out of the lookup function so the function only performs lookup\n\nThis Draft PR covers both files from the supplied codecheck report and remains intentionally scoped to those files.\n\n## Validation\n\n-git diff --check\n-VPTOBufferMaterialization.cpp.obuilds with project C++17 and-Werror\n- lizard: Mad dispatch and VCVT lookup are below the reported complexity threshold; load distribution parsing is table-driven\n- emitter compile reaches only unchanged LLVM-environment incompatibilities: selected LLVM lacks CANN900 low-precision LLVM types andllvm::CallingConv::SimtEntry\n