fix(vpto): combine reductions before scheduling - #1358
Merged
mouliangyu merged 1 commit intoAug 27, 2026
Merged
Conversation
A3 板测完成（有跳过）
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
VPTOCombineReductionsbefore the optionalVPTOSchedulerin the VPTO emission pipeline.Rationale
VPTOCombineReductionschanges the physical reduction tree and therefore the MI instruction set and dependencies. Scheduling after the combine pass ensures the scheduler analyzes the final reduction form while retaining the pass prerequisite that mask simplification, LICM, and CSE have already stabilized VPTO producers.Validation
git diff --checkninja -C build-llvm19 tools/ptoas/obj.PTOASCompilerImplementationRelated context: the pass was previously left after scheduler when scheduler integration was added, which made scheduling observe the pre-combine reduction tree.