Skip to content

[VPTO] Remediate CodeArts codecheck findings - #1414

Closed
Zhendong404 wants to merge 6 commits into
hw-native-sys:mainfrom
Zhendong404:codex/codecheck-remediation
Closed

[VPTO] Remediate CodeArts codecheck findings#1414
Zhendong404 wants to merge 6 commits into
hw-native-sys:mainfrom
Zhendong404:codex/codecheck-remediation

Conversation

@Zhendong404

@Zhendong404 Zhendong404 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remediate confirmed CodeArts findings across VPTO transforms
  • add explicit namespace-qualified pass factories and safer integer checks
  • preserve MLIR pass interface constraints and document framework false positives

Validation

  • git diff --check
  • ninja -C /home/zhangzhendong/ptoas-workspace/builds/codecheck-remediation

The changes are based on the latest official/main.

@Zhendong404

Zhendong404 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

PTOAS/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
PTOAS/lib/PTO/Transforms/VPTOLLVMEmitterHelper.cpp
PTOAS/lib/PTO/Transforms/VPTOMaskSimplify.cpp
PTOAS/lib/PTO/Transforms/VPTONormalizeContainer.cpp
PTOAS/lib/PTO/Transforms/VPTOOptimizeVcvt.cpp
PTOAS/lib/PTO/Transforms/VPTOPtrCastCleanup.cpp
PTOAS/lib/PTO/Transforms/VPTOPtrNormalize.cpp
PTOAS/lib/PTO/Transforms/VPTOScheduler/VPTOSchedDAGBuilder.cpp
PTOAS/lib/PTO/Transforms/VPTOScheduler/VPTOSchedulerPass.cpp
PTOAS/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
PTOAS/lib/PTO/Transforms/VPTOSplitCVModule.cpp
PTOAS/lib/SoftOps/div_int.py
PTOAS/lib/SoftOps/trig.py
PTOAS/lib/TileOps/a5/
PTOAS/lib/TileOps/a5/_col_arg.py
PTOAS/lib/TileOps/a5/_elementwise.py
PTOAS/lib/TileOps/a5/_remainder.py
PTOAS/lib/TileOps/a5/div_hp.py
PTOAS/lib/TileOps/a5/tcmp.py
PTOAS/lib/TileOps/a5/tcmps.py
PTOAS/lib/TileOps/a5/tcvt.py
PTOAS/lib/TileOps/a5/tdequant.py
PTOAS/lib/TileOps/a5/tload.py
PTOAS/lib/TileOps/a5/trandom.py
PTOAS/lib/TileOps/a5/tscatter.py
PTOAS/lib/TileOps/a5/tsel.py
PTOAS/lib/TileOps/a5/tsels.py
PTOAS/lib/TileOps/a5/tsort32.py
PTOAS/lib/TileOps/a5/ttrans.py
PTOAS/packaging/ptoas-vmi/prepare_source.py
PTOAS/ptodsl/ptodsl/_allreduce.py
PTOAS/ptodsl/ptodsl/_ast_rewrite.py

@Zhendong404

Zhendong404 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author
56 1f4c60edd4b0e87469aae4a004c55ecd clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::MulOverflow(*c, scale, scaled) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 400 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
56 1f4c60edd4b0e87469aae4a004c55ecd clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::MulOverflow(*c, scale, scaled) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 408 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
109 361970f77138e5a1136a84703618f4dc clangTidy G.EXP.36-CPP 控制表达式的结果应是布尔值 huawei-bool-in-condition-expr addAffineTerm() if (llvm::AddOverflow(form.terms[i].coeff, coeff, result)) { The controlling expression (if) must be a Boolean value or a Pointer rather than 'std::enable_if_t<std::is_signed_v, long>' 371 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
117 38c3e296fb19272e6004b3d3d901f09b clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda analyzeFunction() std::function<void(Region &)> analyzeRegion = [&](Region &parentRegion) { use of default capture (reference) in lambda expression 208 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedulerPass.cpp
178 59c3ccf2bb428dabb346d9da721fbae7 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda hasSectionKind() WalkResult result = funcOp.walk([&](Operation *op) { use of default capture (reference) in lambda expression 115 pto-as/lib/PTO/Transforms/VPTOSplitCVModule.cpp
180 5ad36e36b780917c87758750441158d2 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type mayAlias() if (!llvm::AddOverflow(*lhs.semantics.byteOffset, *lhs.semantics.byteSize, The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 88 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedDAGBuilder.cpp
186 5ef7db884855c11b8ea45dd1e6424d46 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::SubOverflow(int64_t{0}, scale, negScale) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 417 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
190 6071cf5c3d3905f28b3b38401722cbd3 clangTidy G.EXP.36-CPP 控制表达式的结果应是布尔值 huawei-bool-in-condition-expr printPressureVector() if (index) The controlling expression (if) must be a Boolean value or a Pointer rather than 'std::tuple_element<0, class std::tuple<unsigned long, const struct mlir::pto::VPTORegPressureSet &> >::type' 45 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedulerPass.cpp
193 624fba9bc3a7cc2c2258e6f388528862 clangTidy G.CNS.03-CPP 对于不会修改成员变量的成员函数应使用const修饰 huawei-member-function-could-be-const processForOp() void processForOp(scf::ForOp forOp, OpBuilder &builder) { member function '(anonymous namespace)::VPTOSoftPostUpdatePass::processForOp' could be made const 2542 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
208 6a8cfeae436b82f7bb360c61ba00e3b8 clangTidy G.EXP.36-CPP 控制表达式的结果应是布尔值 huawei-bool-in-condition-expr addAffineConstant() if (llvm::AddOverflow(form.constant, value, result)) { The controlling expression (if) must be a Boolean value or a Pointer rather than 'std::enable_if_t<std::is_signed_v, long>' 355 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
243 7a0c5338ae024555377dd7dc672f1a1f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda queryDefaultTargetAttrs() auto cleanup = llvm::make_scope_exit(& { use of default capture (reference) in lambda expression 311 pto-as/lib/PTO/Transforms/VPTOLLVMEmitterHelper.cpp
271 8668a6c902343e8759c1d3bbe4eee804 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda VPTOSchedDAGBuilder::buildMemoryEdges() [&](const ResolvedMemoryAccess &predecessor) { use of default capture (reference) in lambda expression 134 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedDAGBuilder.cpp
273 8711b18a2bbb3c5d0075a95bff827e60 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::MulOverflow(scale, *lhsConst, newScale) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 424 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
293 8f350b0a103d55cb1b0dec3c08b5a7cb clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::MulOverflow(scale, *rhsConst, newScale) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 429 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
296 8f6919fbd6445f077132326eaa12f94b clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type accumulateAffine() return !llvm::MulOverflow(e->constant, scale, scaled) && The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 394 pto-as/lib/PTO/Transforms/VPTOSoftPostUpdate.cpp
301 932218d0599192046dcc52c3e27f52c7 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda queryDefaultTargetAttrs() auto stderrCleanup = llvm::make_scope_exit(& { use of default capture (reference) in lambda expression 332 pto-as/lib/PTO/Transforms/VPTOLLVMEmitterHelper.cpp
312 98749f6931e0762ba98175489d365cfb clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda VPTOSchedRegionBuilder::build() auto flush = [&](Operation *followingBoundary, StringRef followingReason) { use of default capture (reference) in lambda expression 73 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedRegion.cpp
330 a5581dcec81ff98bb021845b240ab0f9 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda hasCVSections() WalkResult result = funcOp.walk([&](Operation *op) { use of default capture (reference) in lambda expression 96 pto-as/lib/PTO/Transforms/VPTOSplitCVModule.cpp
416 cf6c1ff8855cb9a38c5b8d78db3e12b2 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda VPTOSchedDAGBuilder::buildMemoryEdges() [&](const ResolvedMemoryAccess &successor) { use of default capture (reference) in lambda expression 137 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedDAGBuilder.cpp
431 d39398e81553cbf7e81ca293dd1caf84 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type mayAlias() !llvm::AddOverflow(*rhs.semantics.byteOffset, *rhs.semantics.byteSize, The operand type of unary operator '!' is improperly 'std::enable_if_t<std::is_signed_v, long>' (aka 'long') 90 pto-as/lib/PTO/Transforms/VPTOScheduler/VPTOSchedDAGBuilder.cpp
504 026745392fadac48d2b2c2bdfce20114 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCbConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2752 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
510 05e1876607600fd6db8e3eaa025c651f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto getI64 = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6062 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
510 05e1876607600fd6db8e3eaa025c651f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto getI64 = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6155 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
510 05e1876607600fd6db8e3eaa025c651f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto getI64 = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6260 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
510 05e1876607600fd6db8e3eaa025c651f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto getI64 = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6451 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
514 07271b07e0d077197d252a00563731d2 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToUbConfig() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2338 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
528 0d15e9d7a82af545f5abb81b56f9714e clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufMultiConfig1() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2552 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
537 129b2e96d5d10742e772b1baba933334 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbCfgV220() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2188 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
538 12cdb51a4d1d9042d61fac86342c2e0c clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToBtConfig() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2586 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
545 15d0dc354873ad07df304abf9f10f4de clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToS4Config1() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2674 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
556 1ac9e8d74b499e143cf6d8e48f374b4b clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shiftField = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6810 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
563 1ea5c06be9c2361da6ee785fcfefa543 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufMultiConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2521 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
564 1eac12de479402227d4d83f15f1cce1b clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCbConfig1() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2782 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
565 1eee6c4710d7c7164d99d6ec1b51e943 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToCbufConfig() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2434 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
610 3c82c4630ae908897a1f62dd913f1621 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2463 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
618 3e97aadedc72fc7ea5d83945cf5cff8a clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2251 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
626 4352faac45a5efda68e38fde06244555 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToUbConfig() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2394 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
632 4722a2f1d41806fcb5dde2e99db38e78 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToBtConfig() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2582 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
646 4f718483bc153f2dda35e631f3c760a2 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto castToI64 = [&](Value value) -> Value { use of default capture (reference) in lambda expression 10674 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
657 5aa18ab1818b55435eb15b9999c99c52 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToFbufConfig() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2615 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
658 5ad097bbe63f6c6e350708f7ef1e518a clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2247 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
675 628793a1fbabb0b087c5f199d1093f88 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbConfig0() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2124 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
681 653ad9b69d4d7e23cd35aaffbc2a5a10 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2144 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
682 671c7e8a436a79fa026e4036891c3051 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() FailureOr calleeName = [&] (MLIRContext *ctx, Type sourceType) use of default capture (reference) in lambda expression 7052 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
691 69a0bdbe07115cf54a3384d986072c58 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToCbufConfig() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2416 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
693 69dfa3e1409cf730d3b644fb43c8489e clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufMultiConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2517 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
696 6adcbc6f32ae7eb21f8a2b4e0c57f70d clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmCfgV220() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2293 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
701 6bb9cf23c440999095b6921de517b4e1 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToFbufConfig() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2619 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
733 7db4758b9320b291e05999e0209b6d20 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCaConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2698 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
734 7de9b5dbb59d1a46b03059a2e987a77c clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToCbufConfig() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2430 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
740 8081bbab939b213f1966cfec10ac675d clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbCfgV220() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2184 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
742 8366d29891c4440de93cc68064d95729 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbCfgV220() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2173 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
743 83cd3b6da5c5680d5b5c14feecd331e3 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToS4Config0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2646 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
746 854374609a523fdc6521c04e5f1b774d clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskField = [&](Value value) -> Value { use of default capture (reference) in lambda expression 6807 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
747 85834e8aa60843612ff1db5754031035 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCaConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2702 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
750 86bbf31fada56ca8d8985fc291f70fa5 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToS4Config0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2650 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
754 88e3a523d503b65cd0e43ebb26474c92 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskByte = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6065 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
754 88e3a523d503b65cd0e43ebb26474c92 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskByte = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6158 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
754 88e3a523d503b65cd0e43ebb26474c92 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskByte = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6263 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
754 88e3a523d503b65cd0e43ebb26474c92 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskByte = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6353 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
754 88e3a523d503b65cd0e43ebb26474c92 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto maskByte = [&](Value v) -> Value { use of default capture (reference) in lambda expression 6454 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
766 8e172658a74963fe3b4b82d9398b3687 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToUbConfig() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2355 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
780 934d7204390646563bf6ca1b4c4774da clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type getNaturalByteAlignment() if (!elemAlign) The operand type of unary operator '!' is improperly 'unsigned int' 220 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
780 934d7204390646563bf6ca1b4c4774da clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type getNaturalByteAlignment() if (!elemAlign) The operand type of unary operator '!' is improperly 'unsigned int' 233 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
797 9b07ac7635fbcbeaa14fcee34ea83600 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shl = [&](Value v, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6070 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
797 9b07ac7635fbcbeaa14fcee34ea83600 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shl = [&](Value v, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6163 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
797 9b07ac7635fbcbeaa14fcee34ea83600 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shl = [&](Value v, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6268 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
797 9b07ac7635fbcbeaa14fcee34ea83600 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shl = [&](Value v, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6358 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
797 9b07ac7635fbcbeaa14fcee34ea83600 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto shl = [&](Value v, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 6459 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
824 a871eb40af6657b27d039bbe3fc36be2 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmCfgV220() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2297 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
831 a9eea2db3eaba0d3e9d81faa2d3875d1 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCaConfig1() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2728 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
838 ad37c93ef37e50a280ec3451cc948dfa clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmConfig0() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2234 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
842 af843164bfc5ac5fd6c9b77caf29f541 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packLoadCbufToCbConfig0() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2756 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
848 b17da1a9d63d997f90f7a497c9b1478c clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto appendRndArg = & -> LogicalResult { use of default capture (reference) in lambda expression 10250 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
853 b584601715a7c395a73bf6abb1a83090 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2459 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
859 b7410be10b96ce3c2f40b6ea5f318beb clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToUbConfig() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2376 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
874 bef78eada861c02510521c45696350ff clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufConfig1() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2487 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
881 c2a2a4010582136f788029eb1e467ec4 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto appendSatArg = & -> LogicalResult { use of default capture (reference) in lambda expression 10263 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
902 cc542cc6e905d962424b483dd1ca1fe3 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packVmrgsort4SourceAddr() auto packOne = [&](Value source, uint64_t laneShift) -> FailureOr { use of default capture (reference) in lambda expression 5076 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
905 cd0ec5a522b5b3053841ed8c3fc91191 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda matchAndRewrite() auto getI64 = [&](Value v) -> Value { return castIntegerLikeTo(op, v, i64Ty); }; use of default capture (reference) in lambda expression 6352 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
918 d229fe3157fcfc596a3d85d8ea85afcf clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufMultiConfig1() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2548 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
933 dbd32c12377bd315246536b0c743ad10 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type normalizeFuncSignaturesForOfficialLLVMLowering() changed |= (normalized != input); The Left operand type of operator '|=' is improperly 'bool' 13760 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
933 dbd32c12377bd315246536b0c743ad10 clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type normalizeFuncSignaturesForOfficialLLVMLowering() changed |= (normalized != input); The Right operand type of operator '|=' is improperly 'bool' 13760 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
965 f27d98d24843889a31c58552efa0796f clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type normalizeFuncSignaturesForOfficialLLVMLowering() changed |= (normalized != result); The Left operand type of operator '|=' is improperly 'bool' 13765 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
965 f27d98d24843889a31c58552efa0796f clangTidy G.EXP.27-CPP 使用恰当的基本类型作为操作符的操作数 huawei-proper-operand-type normalizeFuncSignaturesForOfficialLLVMLowering() changed |= (normalized != result); The Right operand type of operator '|=' is improperly 'bool' 13765 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
976 f68f6ce42939572d64395a1191b8ec6b clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToUbConfig() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2351 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
978 f705756f9541c5e6c9fbccbf75a4851f clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyCbufToUbConfig() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2390 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
982 f8ff61c47d13012452e2f00c9e5a8930 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToUbConfig0() auto shl = [&](Value value, uint64_t amount) -> Value { use of default capture (reference) in lambda expression 2140 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
985 f97205b7690ed7890d88cb1e478203c1 clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyGmToCbufConfig1() auto bitOr = [&](Value lhs, Value rhs) -> Value { use of default capture (reference) in lambda expression 2491 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
988 f9fcaa6adf9e1f5332840849c90367fc clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda packCopyUbToGmCfgV220() auto getI64Operand = [&](unsigned idx) -> Value { use of default capture (reference) in lambda expression 2282 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp
991 fcc2084f2ebf08dbe349840ccc0cc5ea clangTidy G.RES.06-CPP 避免lambda表达式使用默认捕获模式 huawei-use-default-capture-in-lambda buildCopyGmToUbCallee() auto getElementSuffix = & -> std::string { use of default capture (reference) in lambda expression 4133 pto-as/lib/PTO/Transforms/VPTOLLVMEmitter.cpp

@Zhendong404

Zhendong404 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

huge_method[PYTHON] the nbnc line of the method {div_i32_soft()} is 76, it is over 50 14 PTOAS/lib/SoftOps/div_int.py
huge_method[PYTHON] the nbnc line of the method {div_i16_soft()} is 84, it is over 50 108 PTOAS/lib/SoftOps/div_int.py
redundant_code[PYTHON] redundant code, please delete it 30 PTOAS/lib/SoftOps/trig.py
redundant_code[PYTHON] redundant code, please delete it 47 PTOAS/lib/SoftOps/trig.py
huge_folder[PYTHON] folder name: PTOAS/lib/TileOps/a5/ [node number: 122] 0 PTOAS/lib/TileOps/a5/
huge_method[PYTHON] the nbnc line of the method {template_i8_ui8()} is 51, it is over 50 137 PTOAS/lib/TileOps/a5/_col_arg.py
huge_method[PYTHON] the nbnc line of the method {register_scalar_binary()} is 96, it is over 50 353 PTOAS/lib/TileOps/a5/_elementwise.py
huge_method[PYTHON] the nbnc line of the method {register_scalar_remainder()} is 53, it is over 50 144 PTOAS/lib/TileOps/a5/_remainder.py
huge_method[PYTHON] the nbnc line of the method {register_binary_remainder()} is 60, it is over 50 53 PTOAS/lib/TileOps/a5/_remainder.py
huge_method[PYTHON] the nbnc line of the method {_div_ieee754_f32_impl()} is 113, it is over 50 81 PTOAS/lib/TileOps/a5/div_hp.py
huge_method[PYTHON] the nbnc line of the method {_div_ieee754_f16_impl()} is 113, it is over 50 260 PTOAS/lib/TileOps/a5/div_hp.py
redundant_code[PYTHON] redundant code, please delete it 369 PTOAS/lib/TileOps/a5/div_hp.py
huge_method[PYTHON] the nbnc line of the method {_emit_tcmp_1d()} is 68, it is over 50 41 PTOAS/lib/TileOps/a5/tcmp.py
huge_method[PYTHON] the nbnc line of the method {_emit_tcmp_2d()} is 78, it is over 50 116 PTOAS/lib/TileOps/a5/tcmp.py
huge_method[PYTHON] the nbnc line of the method {_emit_tcmps_2d()} is 79, it is over 50 105 PTOAS/lib/TileOps/a5/tcmps.py
huge_method[PYTHON] the nbnc line of the method {_emit_tcmps_1d()} is 57, it is over 50 41 PTOAS/lib/TileOps/a5/tcmps.py
huge_method[PYTHON] the nbnc line of the method {_render_tcvt_si8_to_i32_1d()} is 57, it is over 50 1047 PTOAS/lib/TileOps/a5/tcvt.py
redundant_code[PYTHON] redundant code, please delete it 139 PTOAS/lib/TileOps/a5/tdequant.py
huge_method[PYTHON] the nbnc line of the method {template_tload_dn2dn()} is 54, it is over 50 115 PTOAS/lib/TileOps/a5/tload.py
huge_cyclomatic_complexity[PYTHON] the cyclomatic complexity of the method {template_tload_nd2nd()} is 22, it is over 20 39 PTOAS/lib/TileOps/a5/tload.py
huge_method[PYTHON] the nbnc line of the method {template_tload_nd2nd()} is 54, it is over 50 39 PTOAS/lib/TileOps/a5/tload.py
huge_method[PYTHON] the nbnc line of the method {template_trandom()} is 56, it is over 50 52 PTOAS/lib/TileOps/a5/trandom.py
huge_method[PYTHON] the nbnc line of the method {template_tscatter_mask_row()} is 54, it is over 50 121 PTOAS/lib/TileOps/a5/tscatter.py
huge_method[PYTHON] the nbnc line of the method {_emit_tsel_2d()} is 81, it is over 50 106 PTOAS/lib/TileOps/a5/tsel.py
huge_method[PYTHON] the nbnc line of the method {_emit_tsel_1d()} is 58, it is over 50 43 PTOAS/lib/TileOps/a5/tsel.py
huge_method[PYTHON] the nbnc line of the method {_emit_tsels_1d()} is 54, it is over 50 74 PTOAS/lib/TileOps/a5/tsels.py
huge_method[PYTHON] the nbnc line of the method {_emit_tsels_2d()} is 77, it is over 50 133 PTOAS/lib/TileOps/a5/tsels.py
huge_method[PYTHON] the nbnc line of the method {template_tsort32_with_tmp()} is 96, it is over 50 136 PTOAS/lib/TileOps/a5/tsort32.py
redundant_code[PYTHON] redundant code, please delete it 133 PTOAS/lib/TileOps/a5/ttrans.py
redundant_code[PYTHON] redundant code, please delete it 78 PTOAS/lib/TileOps/a5/ttrans.py
huge_method[PYTHON] the nbnc line of the method {prepare_source()} is 104, it is over 50 92 PTOAS/packaging/ptoas-vmi/prepare_source.py
huge_method[PYTHON] the nbnc line of the method {_emit_cross_warp_reduce()} is 67, it is over 50 160 PTOAS/ptodsl/ptodsl/_allreduce.py
huge_cyclomatic_complexity[PYTHON] the cyclomatic complexity of the method {_eval_static_int_values()} is 22, it is over 20 859 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_rewrite_nested()} is 57, it is over 50 1645 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_rewrite_if()} is 279, it is over 50 1705 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_cyclomatic_complexity[PYTHON] the cyclomatic complexity of the method {_rewrite_for()} is 27, it is over 20 2042 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_rewrite_controlled_for()} is 147, it is over 50 2407 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_cyclomatic_complexity[PYTHON] the cyclomatic complexity of the method {_rewrite_if()} is 21, it is over 20 1705 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_definite_out_stmt()} is 52, it is over 50 728 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {rewrite_stmt()} is 56, it is over 50 1587 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_rewrite_while()} is 165, it is over 50 2571 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {rewrite_jit_function()} is 69, it is over 50 23 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_cyclomatic_complexity[PYTHON] the cyclomatic complexity of the method {_rewrite_while()} is 27, it is over 20 2571 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_non_headerfile[PYTHON] the nbnc line of the non header file is 2282, it is over 2000 0 PTOAS/ptodsl/ptodsl/_ast_rewrite.py
huge_method[PYTHON] the nbnc line of the method {_rewrite_for()} is 283, it is over 50 2042 PTOAS/ptodsl/ptodsl/_ast_rewrite.py

@github-actions
github-actions Bot force-pushed the main branch 2 times, most recently from 4687426 to 7e2ec3e Compare September 4, 2026 10:01
@Zhendong404
refactor(vpto): remediate VPTO LLVM emitter codecheck findings
fc9ea5b 
Consolidate the codecheck remediation series into a single change:

- split the oversized VPTOLLVMEmitter into focused translation units
- share and deduplicate helper fragments across emitters (cube memory
  config, ubuf/vector/copy lowering, sync config, scalar fragments)
- simplify and split oversized matchAndRewrite bodies
- remove dead patterns and unused duplicate helpers
- fix dangling StringRef temporaries and drop overloaded-virtual
  suppressions while keeping lowering registrations intact
- resolve the remaining duplicate-code findings: reuse the existing
  packShiftedFields helper for copy config packing, reuse the shared
  vector-2 float fragment helper for atomic element fragments, replace
  the duplicated width switch with a compact formatter, and factor the
  common gather call tail into a shared helper

All findings in the exported codecheck list are cleared; the legacy
VPTOCANN900LLVMEmitter* files are left untouched.
@Zhendong404
fix(vpto): restore local copy lowering and drop duplicated CANN900 he…
668fb8b 
…lpers

Address the PR review on the emitter split:

- restore lowering for pto.copy_ubuf_to_ubuf / copy_cbuf_to_ubuf /
  copy_ubuf_to_cbuf (config packing, .v310 callee builders and conversion
  patterns) so modules reaching the beta1 emitter no longer hard-fail on
  the illegal-op list; add a vpto-llvm RUN line covering the cbuf/ubuf
  copies in cube_store_dma_copy.pto
- delete the duplicate detail-scope PlannedDecl/LoweringState/
  VPTOTypeConverter/getI64Constant/getI32Constant/parse*Immediate and
  mad-fragment helpers from the CANN900 internal header: the shared
  VPTOLLVMEmitter definitions are now the single source (the shared
  parseVcvtPartImmediate keeps the P0/P1 aliases the CANN900 path
  previously accepted)
- include the remaining duplicate-code cleanups that were missing from the
  committed tree: reuse packShiftedFields for the legacy copy packing,
  share the vector-2 float fragment helper, and factor the common gather
  call tail
@Zhendong404
fix(vpto): split oversized local-copy matchAndRewrite
92e04c1 
Shrink LowerLocalCopyOpPattern::matchAndRewrite below the 50-line limit
flagged by the oversized-function codecheck: extract pointer validation /
address-space retargeting into prepareLocalCopyPointers and callee+config
selection into getLocalCopyCalleeAndConfig.
@Zhendong404
fix(vpto): restore full license header in split emitter files
491f586
@Zhendong404
Zhendong404 force-pushed the codex/codecheck-remediation branch from 478b46c to 491f586 Compare September 4, 2026 15:42
@Zhendong404
ci: repair GitHub mirror build checks
4d40958 
- Refresh the ptoas-vmi pyproject patch for the current requires-python floor.
- Set legacy CMake policies before fetching cann-cmake and default the
  third-party directory into the writable CMake binary tree when unset.
@Zhendong404
Zhendong404 force-pushed the codex/codecheck-remediation branch from 7da5b23 to 4d40958 Compare September 4, 2026 16:07
@Zhendong404

Zhendong404 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

/run a5

@reedhecre

reedhecre commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

已接收 /run a5，A5 板测器会处理这条请求。

页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。

@Zhendong404
test(vpto): gate fatobj lit case on CANN toolchain
9621ab3 
The mixed low-precision MAD cube lit case needs a real CANN toolchain for
VPTO fatobj emission; hosted CI runners without ASCEND_HOME_PATH fail the
run at pto.mad_raw legalization. Advertise a new 'ascend-toolchain' lit
feature only when a CANN9 install is discoverable under ASCEND_HOME_PATH
and mark the case REQUIRES it so it is reported UNSUPPORTED off-toolchain.
Also drop the duplicated license tail in test/lit/lit.cfg.py.
@reedhecre

reedhecre commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

A5 板测失败

  • 触发方式：manual
  • 源码提交：f1ba011fa6e4
  • 结果汇总：OK 628 / FAIL 24 / SKIP 47
  • 日志：/root/ptoas-board-monitor-a5/logs/20260905_002807_manual_pr1414.log
  • 结果 TSV：/root/ptoas-board-monitor-a5/logs/20260905_002807_manual_pr1414.tsv
  • 手动指令：/run a5
  • 触发人：Zhendong404
  • 触发评论：[VPTO] Remediate CodeArts codecheck findings #1414 (comment)
  • 失败阶段：board-validation / exit=1

失败用例

  • TquantMx/tquant_mx (run, exit=2)
  • Sels/sels (run, exit=2)
  • Sel/sel (run, exit=2)
  • Scatter/scatter (run, exit=2)
  • Rowexpandsub/rowexpandsub (run, exit=2)
  • Rowexpandmul/rowexpandmul (run, exit=2)
  • Rowexpandmax/rowexpandmax (run, exit=139)
  • Rowexpanddiv/rowexpanddiv (run, exit=2)
  • Partmin/partmin (run, exit=2)
  • Not/not (run, exit=139)
  • Movfp/movfp_fixpipe_reuse (run, exit=2)
  • Interleave/tinterleave (run, exit=2)
  • DeInterleave/tdeinterleave (run, exit=2)
  • DeepseekV4ProDecodeA5/hc_pre_linear (run, exit=139)
  • DeepseekV4ProDecodeA5/csa_cmp_rope (run, exit=139)
  • DeepseekV4ProDecodeA5/idx_qr_proj_dequant (run, exit=139)
  • DeepseekV4FlashDsparkA5/prefill_c4_rmsnorm_rope (run, exit=139)
  • DeepseekV4DecodeA5/kv_hadamard (run, exit=139)
  • DeepseekV4DecodeA5/kv_proj_matmul (run, exit=139)
  • DeepseekV4DecodeA5/csa_cmp_rope (run, exit=139)
  • DeepseekV3_2PrefillBackA5/deepseek_v3_2_prefill_back_layer_incore_9 (run, exit=139)
  • Colexpandadd/colexpandadd (run, exit=139)
  • Cmps/cmps (run, exit=2)
  • Cmp/cmp (run, exit=2)

@Zhendong404
Zhendong404 deleted the branch hw-native-sys:main September 5, 2026 08:52
@Zhendong404 Zhendong404 closed this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zhendong404 @reedhecre