Skip to content

Conversation

@craigmillernz
Copy link
Contributor

This pull request updates the build system to use meson and updates several deprecated pieces of code to work with python 3.14

@craigmillernz craigmillernz marked this pull request as ready for review January 27, 2026 02:35
@craigmillernz
Copy link
Contributor Author

i'll try again with a new update

@craigmillernz
Copy link
Contributor Author

build tests can be run. It should build on windows, linux and mac os now

The tests.yml might need to be updated

name: install package
run: |
python build.py

then pip install . --no-build-isolation

This could also be tested on windows now.

Build.py makes the etpred.pyd file and the pip install . --no-build-isolation will install it in sitepackages dir

@trichter
Copy link
Collaborator

Hi! Really nice work here! I struggled several times to move the build system to meson. I will review your changes soonish.

@trichter
Copy link
Collaborator

trichter commented Jan 29, 2026

I added a few changes on top of your branch. The build script is now invoked from setup.py, which allows the package to be to installed with a single pip call. Running the build script manually beforehand is still supported.

I also updated the README and CI tests. Everything installs and works out-of-the-box in Linux and MacOS . I'm not sure what the remaining issue is on Windows, and I can’t test it locally. Could you confirm whether the current HEAD of this branch works on your Windows machine?

If @hydrogeoscience has no further comments, I think this PR is ready to be merged.

As a side note, there are quite a few cosmetic changes to unrelated code. I assume these are the result of automatic formatting by your IDE.

@craigmillernz
Copy link
Contributor Author

craigmillernz commented Jan 29, 2026

Hi, thanks for improving all my changes! Makes sense to combine the build script into the setup.py, Don't know why i didn't think of that. It looks like your windows tests succeeded, so do you still want me to test on windows? I'll give it a go regardless.
Update. Yes pip install . works fine on python 3.14 on windows. So i think it's good to go.

@trichter trichter merged commit 41aca9a into hydrogeoscience:master Feb 2, 2026
@trichter
Copy link
Collaborator

trichter commented Feb 2, 2026

Thanks again 👍 I’ve released a new version (v0.8.0), which is now available on PyPI.
Two follow-up steps come to mind:

  1. Migrating the build system from setuptools to meson-python.
  2. Setting up cibuildwheel to automatically build wheels for all supported platforms and publish these on PyPI.

But I guess, we will leave that for next time.

@craigmillernz
Copy link
Contributor Author

craigmillernz commented Feb 2, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants