-
Notifications
You must be signed in to change notification settings - Fork 20
Esnz updates #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esnz updates #45
Conversation
|
i'll try again with a new update |
|
build tests can be run. It should build on windows, linux and mac os now The tests.yml might need to be updated then pip install . --no-build-isolation This could also be tested on windows now. Build.py makes the etpred.pyd file and the pip install . --no-build-isolation will install it in sitepackages dir |
|
Hi! Really nice work here! I struggled several times to move the build system to meson. I will review your changes soonish. |
|
I added a few changes on top of your branch. The build script is now invoked from setup.py, which allows the package to be to installed with a single pip call. Running the build script manually beforehand is still supported. I also updated the README and CI tests. Everything installs and works out-of-the-box in Linux and MacOS . I'm not sure what the remaining issue is on Windows, and I can’t test it locally. Could you confirm whether the current HEAD of this branch works on your Windows machine? If @hydrogeoscience has no further comments, I think this PR is ready to be merged. As a side note, there are quite a few cosmetic changes to unrelated code. I assume these are the result of automatic formatting by your IDE. |
142129b to
c935c8c
Compare
|
Hi, thanks for improving all my changes! Makes sense to combine the build script into the setup.py, Don't know why i didn't think of that. It looks like your windows tests succeeded, so do you still want me to test on windows? I'll give it a go regardless. |
|
Thanks again 👍 I’ve released a new version (v0.8.0), which is now available on PyPI.
But I guess, we will leave that for next time. |
|
That’s great! Nice to get this revived hopefully for a few more years….
There are a couple of other install related issues that could perhaps be closed now?
C.
From: Tom Eulenfeld ***@***.***>
Sent: Tuesday, 3 February 2026 01:00
To: hydrogeoscience/pygtide ***@***.***>
Cc: Craig Miller ***@***.***>; State change ***@***.***>
Subject: Re: [hydrogeoscience/pygtide] Esnz updates (PR #45)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe:
[https://avatars.githubusercontent.com/u/2046150?s=20&v=4]trichter left a comment (hydrogeoscience/pygtide#45)<#45 (comment)>
Thanks again 👍 I’ve released a new version (v0.8.0), which is now available on PyPI.
Two follow-up steps come to mind:
1. Migrating the build system from setuptools to meson-python.
2. Setting up cibuildwheel to automatically build wheels for all supported platforms and publish these on PyPI.
But I guess, we will leave that for next time.
—
Reply to this email directly, view it on GitHub<#45 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJYJSXVENZHGO7LAB3Z3RT4J435RAVCNFSM6AAAAACS7M7RT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMZUG4YDMMZRGQ>.
You are receiving this because you modified the open/close state.Message ID: ***@***.******@***.***>>
Craig Miller
Senior Volcano Geophysicist
+64 27 444 7233
114 Karetoto Road, RD4, Taupo 3384, New Zealand
Earth Sciences New Zealand
[Earth Sciences New Zealand]<https://earthsciences.nz>
The Institute of Geological and Nuclear Sciences Limited and the National Institute of Water and Atmospheric Research Limited joined to become the New Zealand Institute for Earth Science Limited. We are known as Earth Sciences New Zealand. For more information on the Earth Sciences transition click here<https://www.gns.cri.nz/assets/share/ESNZ-2-Stakeholder-information-for-website.pdf>.
Notice: This email and any attachments may contain information which is confidential and/or subject to copyright or legal privilege, and may not be used, published or redistributed without the prior written consent of Earth Sciences New Zealand. If you are not the intended recipient, please immediately notify the sender and delete the email and any attachments. Any opinion or views expressed in this email are those of the individual sender and may not represent those of Earth Sciences New Zealand.
For information about how we process data and monitor communications please see our privacy policy<https://www.gns.cri.nz/contact-us/privacy-policy>.
|
This pull request updates the build system to use meson and updates several deprecated pieces of code to work with python 3.14