[PR] dylanaraps/neofetch#2074 from bgkillas - very useless code cleanup

Upstream PR: dylanaraps/neofetch#2074 Thanks to @bgkillas Co-authored-by: bgkillas <[email protected]>
hykilpikonna · Jul 31, 2022 · 6086ea7 · 6086ea7
2 parents 3ff1e38 + e4fecc6
commit 6086ea7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/neofetch b/neofetch
@@ -2799,7 +2799,7 @@ get_memory() {
                 pages_wired="$(vm_stat | awk '/ wired/ { print $4 }')"
                 pages_compressed="$(vm_stat | awk '/ occupied/ { printf $5 }')"
                 pages_compressed="${pages_compressed:-0}"
-                mem_used="$(((${pages_app} + ${pages_wired//.} + ${pages_compressed//.}) * hw_pagesize / 1024 / 1024))"
+                mem_used="$(((pages_app + ${pages_wired//.} + ${pages_compressed//.}) * hw_pagesize / 1024 / 1024))"
             fi
         ;;
 
@@ -4006,12 +4006,12 @@ get_local_ip() {
 }
 
 get_public_ip() {
-    if [[ ! -n "$public_ip_host" ]] && type -p dig >/dev/null; then
+    if [[ -z "$public_ip_host" ]] && type -p dig >/dev/null; then
         public_ip="$(dig +time=1 +tries=1 +short myip.opendns.com @resolver1.opendns.com)"
        [[ "$public_ip" =~ ^\; ]] && unset public_ip
     fi
 
-    if [[ ! -n "$public_ip_host" ]] && [[ -z "$public_ip" ]] && type -p drill >/dev/null; then
+    if [[ -z "$public_ip_host" ]] && [[ -z "$public_ip" ]] && type -p drill >/dev/null; then
         public_ip="$(drill myip.opendns.com @resolver1.opendns.com | \
                      awk '/^myip\./ && $3 == "IN" {print $5}')"
     fi