-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RetryingCaller and AsyncRetryingCaller #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
On a second look, and before I release anything – wouldn't it make more sense if I.e.: rc = RetryingCaller()
rc(httpx.HTTPError, func, kw=42) You could get current behavior with: rc = partial(RetryingCaller(), httpx.HTTPError) For all I care, I could add some syntactic sugar: rc = RetryingCaller().on(httpx.HTTPError) wdyt? |
Are I like adding |
I think there's definitely the case for reuse where you want the same retry parameters but different errors to retry on. |
fixed/implemented in #57 |
Implements #45
Please lmk if it does what you need @RonnyPfannschmidt.