Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instrumentation hooks to be contextmanagers #95

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Conversation

hynek
Copy link
Owner

@hynek hynek commented Feb 22, 2025

hopefully fixes #84

wdyt @lopopolo-openai?

@hynek
Copy link
Owner Author

hynek commented Mar 4, 2025

@lopopolo-openai ping 😇

Copy link

@lopopolo-openai lopopolo-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! love that we can set this up at app boot and every callsite gets to benefit from it

@lopopolo-openai
Copy link

I do think the docs could use a bit more well motivated of an example. our concrete use case is to emit spans to datadog using ddtrace.

@lopopolo-openai
Copy link

thanks @hynek!

@hynek hynek merged commit b163605 into main Mar 12, 2025
23 checks passed
@hynek hynek deleted the retry-hooks-cm branch March 12, 2025 07:18
@hynek
Copy link
Owner Author

hynek commented Mar 12, 2025

Enjoy, it's live on PyPI! 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants