Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of expo as a peer dependency is causing warnings #60

Open
doelgonzo opened this issue Sep 6, 2023 · 0 comments · May be fixed by #68
Open

Inclusion of expo as a peer dependency is causing warnings #60

doelgonzo opened this issue Sep 6, 2023 · 0 comments · May be fixed by #68

Comments

@doelgonzo
Copy link

Describe the bug
"expo" is listed as a dependency in the core project but only used in the Example project. Is there a reason for this? It is causing warnings to be thrown in non-expo projects due to a missing peer dependency. Maybe it needs to move to devDependencies?

To Reproduce
In a non-expo project, add "@react-native-seoul/masonry-list": "1.4.2", to package.json and run yarn install, see warning:

YN0002: │ @test/mobile@workspace:packages/mobile doesn't provide expo (pb91be), requested by @react-native-seoul/masonry-list

Expected behavior
No warnings should print to console unless expo is being used in the core project itself. Maybe we need

Screenshots
N/A

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

N/A

Additional context
using Yarn 3 and it shows warnings to help manage peer deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant