Using only custom audio settings if provided #549
+91
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
reviewed
Sep 16, 2023
Owner
hyochan
left a comment
hyochan
left a comment
There was a problem hiding this comment.
Thanks for the contribution! @MorganTrudeau Could you kindly check the comment?
| AVLinearPCMIsNonInterleaved: avLPCMIsNonInterleaved ?? false, | ||
| AVEncoderBitRateKey: bitRate! | ||
| ] as [String : Any] | ||
| let settings = customSettings.count > 0 ? customSettings : defaultSettings |
Owner
There was a problem hiding this comment.
Wouldn't this ignore the default values when one of customSettings provided? For example, when AVSampleRateKey is provided, what are other default values be?
hyochan
force-pushed
the
main
branch
3 times, most recently
from
11feb3a to
14b6492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue for me (https://github.com/hyochan/react-native-audio-recorder-player/issues/366). Seems there is conflict between some encodings and other settings. Right now there is no way to stop the library from sending default values. In this pull request if you provide custom audio settings it will only use those settings. If custom audio settings are not passed in then defaults are used.