Skip to content

fix: config ndkVersion #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntcong91 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: config ndkVersion #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ android {
defaultConfig {
minSdk getExtOrIntegerDefault("minSdkVersion")
targetSdk getExtOrIntegerDefault("targetSdkVersion")
ndkVersion getExtOrDefault("ndkVersion")
Copy link

@coderabbitai coderabbitai bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# First, let's look at the android/build.gradle file to understand the current structure
cat -n android/build.gradle | head -50

Repository: hyochan/react-native-nitro-sound

Length of output: 1997

🏁 Script executed:

# Search for all ndkVersion usages in the codebase
rg -n 'ndkVersion' --type groovy --type gradle

Repository: hyochan/react-native-nitro-sound

Length of output: 290

🏁 Script executed:

# Check if there are any gradle.kts files that might also use ndkVersion
fd -e gradle.kts --exec grep -n 'ndkVersion' {}

Repository: hyochan/react-native-nitro-sound

Length of output: 58

🏁 Script executed:

# Examine the getExtOrDefault function definition
cat -n android/build.gradle | grep -A 5 -B 2 'getExtOrDefault'

Repository: hyochan/react-native-nitro-sound

Length of output: 1005

🏁 Script executed:

# Look for any AGP version or gradle plugin declarations
cat -n android/build.gradle | grep -E '(plugins|gradle|agp|AGP|classpath)'

Repository: hyochan/react-native-nitro-sound

Length of output: 224

🏁 Script executed:

# Check the example app's build.gradle context around line 76
sed -n '70,85p' example/android/app/build.gradle

Repository: hyochan/react-native-nitro-sound

Length of output: 675

🏁 Script executed:

# Get broader context to see the block structure
sed -n '1,100p' example/android/app/build.gradle | cat -n

Repository: hyochan/react-native-nitro-sound

Length of output: 4763

🏁 Script executed:

# Check the root build.gradle to understand the structure better
cat -n example/android/build.gradle | head -50

Repository: hyochan/react-native-nitro-sound

Length of output: 769

🏁 Script executed:

# Search for any documentation or comments about ndkVersion placement in the repo
rg -n 'ndkVersion' -B5 -A5 --type groovy --type gradle

Repository: hyochan/react-native-nitro-sound

Length of output: 2047

🏁 Script executed:

# Check if there are any Gradle wrapper or AGP version declarations
find . -name "gradle-wrapper.properties" -o -name "build.gradle" | xargs grep -l "com.android.tools.build:gradle"

Repository: hyochan/react-native-nitro-sound

Length of output: 106

🏁 Script executed:

# Let's verify if AGP actually throws an error for ndkVersion in defaultConfig
# by checking if there are any Kotlin source files or documentation in the repo
find . -name "*.kt" -type f | head -5

Repository: hyochan/react-native-nitro-sound

Length of output: 431

🏁 Script executed:

# Check if there are any gradle plugin or AGP version hints
rg -n 'gradle.*version|agp|AGP' --type groovy | head -20

Repository: hyochan/react-native-nitro-sound

Length of output: 160

🌐 Web query:

Android Gradle Plugin ndkVersion property defaultConfig vs android block placement

💡 Result:

  • Official/idiomatic placement (AGP DSL): ndkVersion is a property of the module’s android {} extension (i.e., CommonExtension.ndkVersion). Set it directly inside android {}, not inside defaultConfig {}. Example from the official DSL reference: android { ndkVersion '20.1.5948944' }. [1]
  • What happens if you don’t set it: AGP will supply a default NDK version depending on the AGP version, so upgrading AGP can implicitly change the NDK unless you lock it with ndkVersion. [1][2]
  • Why defaultConfig { ndkVersion ... } sometimes “works”: in Groovy DSL, nested blocks can sometimes resolve unknown properties via dynamic delegation, so you may see Stack Overflow answers that put ndkVersion under defaultConfig. But it’s not the documented location, is not how the DSL is defined, and is more likely to fail in Kotlin DSL (and/or be fragile across AGP versions). Prefer android { ndkVersion ... }. [1][2]

Recommended (Kotlin DSL):

android {
  ndkVersion = "26.1.10909125"
}

Recommended (Groovy DSL):

android {
  ndkVersion "26.1.10909125"
}

Sources: official AGP DSL (CommonExtension.ndkVersion) [1], NDK/AGP behavior notes (default NDK + android.ndkVersion) [2].

[1] https://developer.android.com/reference/tools/gradle-api/8.3/com/android/build/api/dsl/CommonExtension
[2] https://github.com/android/ndk-samples/wiki/Configure-NDK-Path

🌐 Web query:

AGP CommonExtension ndkVersion DefaultConfig API reference

💡 Result:

  • ndkVersion is a property on com.android.build.api.dsl.CommonExtension (i.e., the top-level android { ... } block for app/library/etc.), not on defaultConfig. It “requires the specified NDK version to be used.” [major.minor.build] format, and it’s mutually exclusive with ndkPath. [1]

  • defaultConfig { ... } is configured via CommonExtension.defaultConfig(...) and uses DefaultConfig / BaseFlavor APIs. NDK-related settings inside defaultConfig are done via the ndk { ... } block (type Ndk) for things like ABI filters (per-variant/per-flavor config), not the NDK version. [1][2]

API reference pages (Android Developers):

CommonExtension (includes ndkVersion, defaultConfig):
https://developer.android.com/reference/tools/gradle-api/8.0/com/android/build/api/dsl/CommonExtension

DefaultConfig (defaultConfig DSL type; inherits ndk { ... } from BaseFlavor/VariantDimension):
https://developer.android.com/reference/tools/gradle-api/8.0/com/android/build/api/dsl/DefaultConfig

Typical Kotlin DSL usage:

android {
  ndkVersion = "26.1.10909125"   // CommonExtension.ndkVersion

  defaultConfig {
    ndk { abiFilters += setOf("arm64-v8a", "x86_64") }  // DefaultConfig/BaseFlavor.ndk { ... }
  }
}

Sources: [1] [2]

Move ndkVersion to the android {} block and guard against null values

ndkVersion is a property of CommonExtension (the android {} block), not DefaultConfig. The Android Gradle Plugin documentation and API reference explicitly define it at the top-level android {} block. Your example app correctly places it at line 76 in example/android/app/build.gradle. Placing it inside defaultConfig {} violates the DSL contract and will cause build failures.

Additionally, getExtOrDefault("ndkVersion") can return null when neither rootProject.ext nor the Sound_ndkVersion project property is set. AGP provides a default NDK version when none is specified, so the safest approach is to skip the assignment entirely when no value is configured—which preserves the pre-PR behavior.

🐛 Proposed fix 
 android {
   namespace "com.margelo.nitro.sound"
 
   compileSdk getExtOrIntegerDefault("compileSdkVersion")
 
+  def ndkVer = getExtOrDefault("ndkVersion")
+  if (ndkVer) {
+    ndkVersion ndkVer
+  }
+
   defaultConfig {
     minSdk getExtOrIntegerDefault("minSdkVersion")
     targetSdk getExtOrIntegerDefault("targetSdkVersion")
-    ndkVersion getExtOrDefault("ndkVersion")
 
     externalNativeBuild {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ndkVersion getExtOrDefault("ndkVersion")
android {
namespace "com.margelo.nitro.sound"
compileSdk getExtOrIntegerDefault("compileSdkVersion")
def ndkVer = getExtOrDefault("ndkVersion")
if (ndkVer) {
ndkVersion ndkVer
}
defaultConfig {
minSdk getExtOrIntegerDefault("minSdkVersion")
targetSdk getExtOrIntegerDefault("targetSdkVersion")
externalNativeBuild {
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@android/build.gradle` at line 27, Move the ndkVersion assignment out of
defaultConfig into the android { } block and only set it when
getExtOrDefault("ndkVersion") returns a non-null/non-empty value; specifically,
locate where ndkVersion is currently being assigned inside defaultConfig, remove
that assignment, and add a guarded assignment inside the android { }
(CommonExtension) configuration that checks the result of
getExtOrDefault("ndkVersion") (or the Sound_ndkVersion project property) and
sets android.ndkVersion only when a value is present so you preserve AGP's
default behavior when no NDK version is configured.


Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This extra blank line appears to be unintentional. Removing it will improve code formatting consistency within the defaultConfig block.


externalNativeBuild {
cmake {
Expand Down