handle orientation consistency in other pathway #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, there are two parallel but different versions of
StandardLayoutOnAllLevels
— one that's attached to theLayoutGeneration
class, and one that lives inLayoutStrategies
. in #88, we addedLimitConfigsToId
to both of these pathways, but one of them (the one utilized by theSpaceType
function) generates thewallCandidateOptions
inside a subsequent methodProcessRoom
, whereas the "built-in" office space types utilize the other, wherewallCandidateOptions
are available at the momentLimitConfigsToId
is called.The functional consequence of this was that built-in types like meeting room had orientation consistency in pringle, but healthcare types generated by
SpaceType
did not.This PR separates out the logic for forcing a certain orientation into a new method
LimitWallCandidateOptionsByConfigId
, which is then called for the other pathway, to ensure consistency.I tested this by releasing a
test
version ofSpaceType
, and ensuring that I got consistently oriented spaces.Massive Future Work / TODO: re-consolidate these pathways so they're not so differently structured (ideally removing one in favor of the other).
This change is