Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle orientation consistency in other pathway #90

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Jan 10, 2024

For some reason, there are two parallel but different versions of StandardLayoutOnAllLevels — one that's attached to the LayoutGeneration class, and one that lives in LayoutStrategies. in #88, we added LimitConfigsToId to both of these pathways, but one of them (the one utilized by the SpaceType function) generates the wallCandidateOptions inside a subsequent method ProcessRoom, whereas the "built-in" office space types utilize the other, where wallCandidateOptions are available at the moment LimitConfigsToId is called.

The functional consequence of this was that built-in types like meeting room had orientation consistency in pringle, but healthcare types generated by SpaceType did not.

This PR separates out the logic for forcing a certain orientation into a new method LimitWallCandidateOptionsByConfigId, which is then called for the other pathway, to ensure consistency.

I tested this by releasing a test version of SpaceType, and ensuring that I got consistently oriented spaces.

Massive Future Work / TODO: re-consolidate these pathways so they're not so differently structured (ideally removing one in favor of the other).


This change is Reviewable

Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained, all discussions resolved

@andrewheumann andrewheumann merged commit 8516f21 into master Jan 11, 2024
1 check passed
@andrewheumann andrewheumann deleted the fix-consistent-orientation branch January 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants