fix: Multiline support for WHERE Input boxes #1208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44bfd83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
teeohhem
force-pushed
the
tom/multiline-inpurt-support
branch
from
8c61c33 to
7cee063
Compare
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 209s
|
teeohhem
commented
Sep 26, 2025
| additionalSuggestions?: string[]; | ||
| queryHistoryType?: string; | ||
| parentRef?: HTMLElement | null; | ||
| allowMultiline?: boolean; |
There was a problem hiding this comment.
We don't want multiline to apply to all SQLInlineEditor instances for the sake of layout continuity.
…yperdx into tom/multiline-inpurt-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: HDX-2427
Closes: HDX-1683
Also adds shift + enter support in these boxes to work within multilines