Fix off by one bug when more data is read than buflen #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same here on some 88 core box (2x22xHyperThread). Right after boot, size of /proc/stat is ~7.5kB, not triggering this bug. This file contains lots of per-cpu-counters increasing over time, while only the first line actually is parsed. Once that file size has increased to >= 8kB, libsigar breaks. |
lizhanyin
added a commit
to lizhanyin/sigar
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was discovered when /proc/stat (on a larger 56 core box) exceeded BUFSIZ=8192,
coming from codepath sigar_cpu_get(), causing a \0 to be written
one byte outside what was allocated, causing a segfault.