Fix RPC name conflicts with generated code #1261
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issues: #747 and #1253
Still a draft - need to add tests
TLDR: Tonic adds predefined methods to codegenned structs, like
connect
. If that name conflicts with an RPC name, the resulting code fails to compile.Solution
This is a problem for other gRPC codegenners too. The C++ one just prepends the problematic method names with a
_
.I took the same approach here.
For example, given the RPC definition
Will generate the following code now