feat: Support thread-local functionality #1505
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature "current-thread" which generates a trait with
#[async_trait(?Send]
, like this:I've tried make the PR as small as possible, but I apologize for the size. But the changes are really simple!
Summary
local_executor
option for tonic-build. So If we activate it, we generate altered code usingasync_trait(?Send)
. We can see an example in ‘tests/current_thread`hyper::Executor
. They are existingTokioExec
and newly addedLocalExec
.Ex
. Its default variable isTokioExec
, so we can preserve compatibility. Plus, to avoid direct access withLocalExec
, we need to use type aliases. For example,Routes
becameRoutes<Ex = TokioExec>
, andLocalRoutes
is added as a type alias forRoutes<LocalExec>
.transport::server::executor::define_serve_with_shutdown
macro. I could not find a better way, but I think we need to wait until Tracking issue for RFC 2515, "Permit impl Trait in type aliases" rust-lang/rust#63063 is finished.