-
Notifications
You must be signed in to change notification settings - Fork 276
Sklearn 1.5 & 1.6 support. Various improvements #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assifier since multinomial_nb does not accept negative values in hashing vectorizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements:
By merging this we will remove support for sklearn 1.4 and under. I aim to create a new release from this and finally tackle the pipy issues that we have discussed a few times before.
Timeline:
I still have to test the pipelines part, then I will request a review. I aim to have this pr finished in the next few days
Edit:
Everything is finished and Ill merge this soon. As soon as I have, I will try to put the project on a new pypi under hyperopt-sklearn. Once successful, this will immediately be followed by a README.md pr. Detailing the install instructions