ArghDA M9 follow-on: Isabelle session-qualified imports (M9 → 98%)#52
Merged
Merged
Conversation
A theory that imports from another session — `imports "HOL-Library.FuncSet"` — is now checkable. (Flat sibling imports already worked: the adapter stages every sibling `.thy` into the session, so `imports Main Foo` on a sibling `Foo` already resolved — verified before touching anything.) The gap was session-qualified imports: the generated ROOT said `= HOL +` with no route to `HOL-Library`, so the build errored "Cannot load theory". Fix: `session_prefixes` scans all staged theories' `imports` clauses for qualified `"Session.Theory"` forms (session = the segment before the first `.`; Isabelle session names are dot-free) and emits a `sessions "<S>" …` clause in the generated ROOT, so `isabelle build` pulls those sessions' heaps. The distribution session heaps ship prebuilt, so the build stays fast (~15 s). Verification (actually run): cargo fmt --check, clippy -D warnings, cargo test (176 pass, +1 `session_prefixes` unit), check-spdx.sh — all green. Dogfooded vs real Isabelle2025: `Q.thy` importing `"HOL-Library.FuncSet"` and using its Pi-notation → proven (was an error pre-fix); flat-sibling regression (`Bar` imports sibling `Foo`) → still proven. Residual: a project with its OWN multi-session ROOT (a locally-defined session importing another local session's theories) — niche; single-theory, flat-sibling and distribution-session-qualified imports all work. This completes the heavy-tail completion cuts (Coq dep-ordering, Mizar cross-refs, Isabelle session-qualified imports). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MpYSh6Wy8YMBH2E3qVyT7
hyperpolymath
marked this pull request as ready for review
July 17, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A theory that imports from another session —
imports "HOL-Library.FuncSet"— is now checkable. This is the last of the heavy-tail completion cuts.Ground-truthed first (the important step): flat sibling imports already worked — the adapter stages every sibling
.thyinto the session, soimports Main Fooon a siblingFooalready resolved. So the real gap was narrower than the milestone text suggested: only session-qualified imports.How
The gap: the generated ROOT said
= HOL +with no route toHOL-Library, so the build errored "Cannot load theory". Fix:session_prefixesscans all staged theories'importsclauses for qualified"Session.Theory"forms (session = the segment before the first.; Isabelle session names are dot-free) and emits asessions "<S>" …clause in the generated ROOT, soisabelle buildpulls those sessions' heaps. The distribution session heaps ship prebuilt, so the build stays fast (~15 s).Verification (actually run)
cargo fmt --check/clippy -D warnings— cleancargo test— 176 pass (+1session_prefixesunit)check-spdx.sh— OKDogfooded vs real Isabelle2025:
Q.thyimporting"HOL-Library.FuncSet", using its Pi-notationproven(waserrorbefore)Barimports siblingFoo)provenScope
M9 → 98%. Residual: a project with its OWN multi-session ROOT (a locally-defined session importing another local session's theories) — niche; single-theory, flat-sibling and distribution-session-qualified imports all work.
This completes the heavy-tail completion cuts (Coq dependency-ordering #50, Mizar cross-refs #51, Isabelle session-qualified imports).
🤖 Generated with Claude Code
https://claude.ai/code/session_012MpYSh6Wy8YMBH2E3qVyT7
Generated by Claude Code