chore(ci): remove temporary print-findings scaffolding from scan wrapper - #551
Merged
Conversation
The print-findings job was triage scaffolding (it cat'd the uploaded hypatia-findings.json to the job log to enumerate self-scan findings without artifact download). It was marked "remove before merge" but shipped to main with #545. Restore the wrapper to its thin form: the scan job + secrets: inherit only. Findings remain available via the hypatia-scan-findings artifact uploaded by the reusable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V13sGvHnaeCY5A9fF2QsDm
hyperpolymath
marked this pull request as ready for review
June 26, 2026 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
print-findingsjob from.github/workflows/hypatia-scan.yml, restoring the wrapper to its thin form (hypatia:job +secrets: inherit).Why
That job was triage scaffolding — it downloaded the
hypatia-scan-findingsartifact andcat'dhypatia-findings.jsonto the job log so the self-scan findings could be enumerated without artifact download. Its own comment says "TEMPORARY (triage scaffolding — remove before merge)", but it shipped tomainwith #545. It adds a redundant download-and-print job to every scan run.The findings are still fully available via the
hypatia-scan-findingsartifact uploaded by the reusable workflow (if: always()), so nothing is lost.No change to the scan itself or the
e2ef79eereusable pin.🤖 Generated with Claude Code
Generated by Claude Code