Skip to content

fix(governance): let the hypatia baseline filter actually run (scan exit-on-findings under bash -e) #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Jul 3, 2026
+11 −1
Merged

fix(governance): let the hypatia baseline filter actually run (scan exit-on-findings under bash -e) #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/governance-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,17 @@ jobs:
BLOCKING_THRESHOLD: info
run: |
echo "Scanning repository: ${{ github.repository }} (checking baseline)"
HYPATIA_FORMAT=json "$HOME/hypatia/hypatia-cli.sh" scan . > hypatia-findings.raw.json
# hypatia's `scan` exits non-zero whenever it finds anything — that is
# by design, and under `bash -e` it would abort this step at this line,
# before the baseline filter (the real gate) ever runs. Tolerate the
# scan's own exit code…
HYPATIA_FORMAT=json "$HOME/hypatia/hypatia-cli.sh" scan . > hypatia-findings.raw.json || true
# …but never swallow a genuine scanner crash into a false pass: require a
# valid JSON array before trusting the output as "the findings".
if ! jq -e 'type == "array"' hypatia-findings.raw.json >/dev/null 2>&1; then
echo "::error::hypatia scan did not produce a valid JSON findings array (scanner error, not a baseline result)"
exit 1
fi

# Relativize finding paths before matching. Hypatia's honest_completion
# and code_safety modules emit ABSOLUTE host paths in `.file`
Expand Down
Loading