fix(governance): point the pin-existence gate at main, not a feature branch - #559
Conversation
…branch #558 merged while the pin-gate checkout was still temporarily pointed at `feat/pin-existence-check`. That ref was a test scaffold: the gate fetches its script from standards, but on the PR branch the script did not yet exist on `main`, so `cp` failed and the step could not be exercised. Pointing at the branch proved the gate works end-to-end (21 pins checked, all resolved, 5s) — but the revert back to `main` landed after the merge. Left as-is, every consumer's governance run checks out a feature branch, and deleting that branch breaks the gate estate-wide. The bootstrap problem it worked around is now gone: check-action-pins-resolve.sh is on main as of #558. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedUpdates the governance pin-existence gate checkout reference from the feature branch to main, ensuring stability after branch deletion. No issues found.
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
1 participant
Urgent follow-up to #558
#558 merged while the pin-gate's standards checkout was still temporarily pointed at
feat/pin-existence-check:Why that ref existed
A bootstrap problem. The gate fetches
check-action-pins-resolve.shfrom standards, but while the PR was open the script did not yet exist onmain— socpfailed with "No such file or directory" and the step could never be exercised. Temporarily pointing at the branch proved the gate works end-to-end in real CI: 21 pins checked, all resolved, 5 seconds, no UNVERIFIED. The revert back tomainwas pushed, but landed after the merge.Why it must be fixed now
Every consumer's Governance run currently checks out a feature branch. Deleting that branch — routine post-merge hygiene — breaks the gate across the estate. The branch is deliberately still alive until this merges.
The bootstrap problem is gone: the script is on
mainas of #558, soref: mainnow resolves correctly.Verified: YAML re-parses with all 11 jobs,
ref = main, zero remaining references to the feature branch.🤖 Generated with Claude Code