-
Notifications
You must be signed in to change notification settings - Fork 0
Add callback support in send method #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
90834e8
feat: add support for callback in send method
GurtejSohi 374572c
chore: dummy commit
GurtejSohi b2c099c
Apply suggestion from @avinashkolluru
avinashkolluru b8bdba6
Apply suggestion from @avinashkolluru
avinashkolluru 2fecdfd
spotless apply
avinashkolluru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
event-store/src/main/java/org/hypertrace/core/eventstore/SendCallback.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package org.hypertrace.core.eventstore; | ||
|
|
||
| /** | ||
| * A callback interface that allows clients to receive notifications when a send operation | ||
| * completes. This can be used to handle both successful sends and errors asynchronously. | ||
| */ | ||
| public interface SendCallback { | ||
|
|
||
| /** | ||
| * Called when a send operation completes. | ||
| * | ||
| * @param result The result of the send operation if successful, null if an exception occurred | ||
| * @param exception The exception thrown during the send operation, null if the send was | ||
| * successful | ||
| */ | ||
| void onCompletion(SendResult result, Exception exception); | ||
| } |
56 changes: 56 additions & 0 deletions
56
event-store/src/main/java/org/hypertrace/core/eventstore/SendResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package org.hypertrace.core.eventstore; | ||
|
|
||
| /** | ||
| * Represents the result of a successful send operation. This class abstracts away the underlying | ||
| * implementation details (e.g., Kafka's RecordMetadata) and provides a common interface for | ||
| * clients. | ||
| */ | ||
| public class SendResult { | ||
|
|
||
| private final String topic; | ||
| private final int partition; | ||
| private final long offset; | ||
| private final long timestamp; | ||
|
|
||
| public SendResult(String topic, int partition, long offset, long timestamp) { | ||
| this.topic = topic; | ||
| this.partition = partition; | ||
| this.offset = offset; | ||
| this.timestamp = timestamp; | ||
| } | ||
|
|
||
| /** Returns the topic the record was appended to. */ | ||
| public String getTopic() { | ||
| return topic; | ||
| } | ||
|
|
||
| /** Returns the partition the record was sent to. */ | ||
| public int getPartition() { | ||
| return partition; | ||
| } | ||
|
|
||
| /** Returns the offset of the record in the topic/partition. */ | ||
| public long getOffset() { | ||
| return offset; | ||
| } | ||
|
|
||
| /** Returns the timestamp of the record in the topic/partition. */ | ||
| public long getTimestamp() { | ||
| return timestamp; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "SendResult{" | ||
| + "topic='" | ||
| + topic | ||
| + '\'' | ||
| + ", partition=" | ||
| + partition | ||
| + ", offset=" | ||
| + offset | ||
| + ", timestamp=" | ||
| + timestamp | ||
| + '}'; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.