feat: use shaded protobuf-java , instead of applications #414
Conversation
| span.setAttribute(key, writer.toString()); | ||
| } catch (IOException e) { | ||
| log.error("Failed to decode message to JSON", e); | ||
| String jsonOutput = ProtobufMessageConverter.getMessage(mb); |
There was a problem hiding this comment.
Why do we need to do this? What was happening while we were directly trying to get it?
There was a problem hiding this comment.
the object we are getting is of com.google.protobuf.Message, this cannot directly be taken as instance of our relocated Message class.
Type Incompatibility: Relocated classes are essentially different types, so couldn’t simply cast one into the other without conversion.
Version Mismatch: two versions (e.g., 3.2.0 vs. 3.25.5) have incompatible internal representations. Like application is using protobuf version 3.2.0, but our bundled dependency of protobuf is 3.25.5.
Different Metadata: The unrelocated message carries descriptors/metadata) that the relocated version doesn't recognize directly.
2 participants
No description provided.