Eason/bugfix #34
Open
Eason/bugfix #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added hyperweb chain info
fix the Coin inport path issue
sdqede
commented
Jul 14, 2025
| @@ -1,10 +1,21 @@ | |||
| { | |||
| "editor.formatOnSave": true, | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
| "[javascript]": { | |||
| "editor.formatOnSave": true, | |||
marslavish
reviewed
Jul 14, 2025
| boxShadow={`0px 4px 20px 0px rgba(${ | ||
| theme === 'light' ? '0,0,0' : '128,128,128' | ||
| }, 0.1)`} | ||
| boxShadow={`0px 4px 20px 0px rgba(${theme === 'light' ? '0,0,0' : '128,128,128' |
| @@ -95,7 +95,7 @@ export const SelectAssetItem = ({ | |||
| > | |||
| <PopoverTrigger> | |||
| <SelectButton | |||
| onClick={() => {}} | |||
| onClick={() => { }} | |||
| @@ -86,7 +86,7 @@ export function Voting({ chainName }: VotingProps) { | |||
| }; | |||
| }); | |||
| break; | |||
| } catch (e) {} | |||
| } catch (e) { } | |||
| </Box> | ||
| ); | ||
| })} | ||
| let tally = proposal.finalTallyResult; |
| @@ -33,7 +33,8 @@ export const useStarshipChains = () => { | |||
|
|
|||
| const assets = (await Promise.all( | |||
| chains.map((chain) => | |||
| fetcher<AssetList>(`${baseUrl}/chains/${chain.chain_id}/assets`) | |||
| // @ts-ignore | |||
| fetcher<AssetList>(`${baseUrl}/chains/${chain.chain_id}/assets`) // if use chainId, got error: Cannot read properties of undefined (reading 'chainName') at const { connect, disconnect, address, wallet } = useChain(selectedChain) | |||
There was a problem hiding this comment.
remove or simplify comments
| @@ -77,8 +104,15 @@ export const useChainUtils = (chainName: string) => { | |||
| }; | |||
|
|
|||
| const getExponentByDenom = (denom: CoinDenom): Exponent => { | |||
| // Special handling for hyperweb native token | |||
| if (denom === 'uhyper') { | |||
| @@ -98,24 +132,39 @@ export const useChainUtils = (chainName: string) => { | |||
| }; | |||
|
|
|||
| const getChainName = (ibcDenom: CoinDenom) => { | |||
| // Special handling for hyperweb native token | |||
| if (ibcDenom === 'uhyper' && chainName === 'hyperweb') { | |||
| const signingClient = await getSigningJsdClient({ | ||
| rpcEndpoint: rpcEndpoint!, | ||
| signer: wallet.getOfflineSignerDirect(chain.chainId ?? ''), | ||
| if (!rpcEndpoint) { |
| arg, | ||
| }); | ||
| return response; | ||
|
|
| @@ -99,7 +99,7 @@ const OverviewTransferWrapper = ( | |||
| const toastHandlers = useToastHandlers(); | |||
| const { data: signingClient } = useSigningClient(sourceChainName); | |||
| const { mutate: transfer, isLoading } = useTransfer({ | |||
| clientResolver: signingClient, | |||
| clientResolver: signingClient as any, | |||
|
I agree with Luca's reviews here, we should strive for strict type safe code unless the interfaces are unknown or can't be patched due to external packages. No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade chain-registry to 2.0
all functionalities works