Suppress a warning in rollup due to the use of #8960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround to suppress a warning thrown by rollup. The warning in question is documented here https://rollupjs.org/guide/en/#error-this-is-undefined
The way it's fixed here is the same approach we used in the rest of the projects where rollup is used:
Testing steps
In
mainbranch, when runningmake devyou should see the assets output include a couple lines likeRollup warning: [...]: The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten (https://rollupjs.org/troubleshooting/#error-this-is-undefined)In this branch, those warnings should not be printed.