Don't log users out so frequently #8961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h/session.py
Outdated
| @@ -126,7 +127,7 @@ def includeme(config): # pragma: no cover | |||
| # | |||
| # To avoid this we make sure that the lifetime of CSRF tokens is always | |||
| # longer than the lifetimes of auth cookies. | |||
| timeout=HTML_AUTHCOOKIE_MAX_AGE + 3600, | |||
| timeout=int(timedelta(hours=1).total_seconds()), | |||
There was a problem hiding this comment.
Shouldn't this be HTML_AUTHCOOKIE_MAX_AGE + ...?
There was a problem hiding this comment.
Yeah, pylint caught that as well. The fact that session_test.py didn't catch this suggests that the unit tests aren't as good as they could be
Fixes #8949. We agreed on logging inactive users out after three months and active users after one year, Slack thread: https://hypothes-is.slack.com/archives/C4K6M7P5E/p1726753077108739?thread_ts=1726473609.158389&cid=C4K6M7P5E
seanh
force-pushed
the
dont-log-users-out-so-frequently
branch
from
ded0890
to
a01d64c
Compare
robertknight
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8949. We agreed on logging inactive users out after three months and active users after one year, Slack thread:
https://hypothes-is.slack.com/archives/C4K6M7P5E/p1726753077108739?thread_ts=1726473609.158389&cid=C4K6M7P5E