Infer function return types & CI failure details#240
Merged
Conversation
When a function has no explicit return-type annotation, walk its body's
return statements and union the statically-resolvable string values so
t(fn()) and t(`...${x}...`) with `const x = fn()` expand correctly. Also
persist captured return sets in a shared cross-file table (populated in
the pre-scan pass, alongside enums) so imported functions resolve just
like in-file ones.
Explicit annotations remain authoritative: `: string` still returns no
keys rather than falling back to body inference.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Prints a summary of what changes would have been applied when running with --ci. This makes it alot easier to see why the command fails in CI environments.
adrai
added a commit
that referenced
this pull request
Apr 20, 2026
Member
|
thx, included in v1.55.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things (can split if that's better):
Infer function return types from body for finite dynamic key resolution
Should extract keys and dynamic keys content that results from function calls with an easily
inferable output type.
Print details of changes for extract --ci
I've had issues with the extraction being flaky with difficulty of reproducing locally. I suspect
there is a race-condition in the extractor. This should help to see where the problem lies, as
well as being generally useful to see what keys are missing when the failure is expected.
Checklist
npm run test