confusing error message getpwuid() #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airblader
reviewed
Apr 12, 2019
| err(EXIT_FAILURE, "getpwuid() failed"); | ||
| else |
There was a problem hiding this comment.
I don't really understand this change – this will now just always error.
|
Since this PR is quite old (sorry for the lack of feedback), small and seems like an odd change I will close for now. If you'd still like to make this change, feel free to comment on my concern above and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #175 the function getpwuid() sets errno to zero while it returns null.
I think that in this case it is not necessary to display errno because it is confusing.