feat: Add MCP secret scrubbing and optional sync#16
Conversation
Summary of ChangesHello @iHildy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the security and flexibility of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable security feature for scrubbing MCP secrets from configuration files before syncing them to a repository. The implementation is well-structured, with the core logic for secret extraction isolated in a new mcp-secrets.ts module, complete with unit tests. The new functionality is correctly wired into the existing sync service, CLI, and configuration handling. The documentation has also been updated accordingly. My review includes one suggestion to make the secret scrubbing logic more robust.
🤖 Review Jules RelayI found 1 Gemini suggestion so far. Type |
Summary
Introduce MCP secret scrubbing and optional commit of MCP secrets in private repos. Add includeMcpSecrets flag and wiring through config, tooling, and tests.
Changes
src/sync/mcp-secrets.tswith MCP secret extraction logicsrc/sync/mcp-secrets.test.tsand extend config tests for new behaviorincludeMcpSecretsinSyncConfig, normalization vianormalizeSyncConfig, and new helpercanCommitMcpSecretssrc/sync/apply.tssrc/sync/service.tsandsrc/index.tsto support enabling secrets withincludeMcpSecretssrc/command/sync-init.md,src/command/sync-enable-secrets.mdto mention MCP secrets optionTesting
bun test(ormise run test)includeSecretsandincludeMcpSecretsenabled, MCP secrets are moved to local overrides and replaced with env placeholders inopencode-synced.overrides.jsoncand synced config contains placeholders