Login-Pau #88
Open
Login-Pau #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2024 12:19
3zcurdia
approved these changes
Jan 25, 2024
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
|
||
| #Preview { | ||
| SignUpView() | ||
| extension String { |
There was a problem hiding this comment.
Comment on lines
-81
to
+62
| .foregroundStyle(.maryBlue) | ||
| .foregroundColor(.maryBlue) |
There was a problem hiding this comment.
this change indicates me that you are using an older version of XCode, when that happen try to avoid to commit those changes
| extension String { | ||
| func isValidPassword() -> Bool { | ||
| // Implement your password validation logic here | ||
| return self.count >= 8 |
There was a problem hiding this comment.
also its only checking for password lenght the other valiations are being skiped
| return password.isValidPassword() | ||
| } | ||
| .assign(to: \.isValidPasswordUpperCase, on: self) | ||
| .assign(to: \.isValidPassword, on: self) |
There was a problem hiding this comment.
the other bindings are being ignored
added 2 commits
January 25, 2024 12:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44