feat(error): add typed public error contract#140
Draft
tcp404 wants to merge 2 commits into
Draft
Conversation
- Introduce ProviderFailure, AgentFailure, and PublicError code mappings so provider errors cross boundaries as structured data. - Replace stream string error events with typed provider stream failures and protocol public errors. - Centralize provider signal classification and document the JSON stream error contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublicErrorprotocol contract with stable code, ownership, and details fieldsProviderFailure/AgentFailureflow and remove provider stream string error eventsVerification
just pushcargo fix --allow-dirty --allow-stagedcargo clippy --fix --workspace --all-targets --allow-dirty --allow-staged -- -D warningscargo fmt --allcargo nextest run --workspace --profile default1968 tests run: 1968 passed, 2 skippedNotes
protocol_parse_failedis reserved in the public code list; the current stdin reader still logs malformed command lines before dispatch.retry_after_msremains internal provider metadata and is not part of the public stream error contract.