code has been improvised to generate fast response by iamananya · Pull Request #15 · iamananya/ginco-task

iamananya · 2023-06-01T11:12:03Z

@GuiltyMorishita the code have been improved for a fast response using hash tables.

The implementation details are:

The GenerateCharacterPool function creates a hash table (probability map) to store the character probabilities. The character ID is used as the key in the hash table, and the probability is the associated value.
The FindCharacterByID function iterates across the probability map and returns the character for each ID. The function directly retrieves the character using the ID from the hash table rather than scanning through the complete character slice for each character.
The character pool is drawn at random using the DrawCharacter function

iamananya · 2023-06-01T11:23:48Z

And for time=100000 the response time is:

iamananya · 2023-06-01T11:28:45Z

Also the results for times=20 are:

R=16/20 which is 80% probability

SR=3/20 which is 15% probability

SSR=1/20 which is 5% probability
The results are according to the probability mentioned in the code. This proves the correctness of the code.

{
"results": [
{
"characterID": "Character-46",
"name": "Xiangling",
"rarity": "R"
},
{
"characterID": "Character-18",
"name": "Venti",
"rarity": "R"
},
{
"characterID": "Character-28",
"name": "Arataki Itto",
"rarity": "R"
},
{
"characterID": "Character-15",
"name": "Mona",
"rarity": "SR"
},
{
"characterID": "Character-13",
"name": "Kazuha",
"rarity": "SR"
},
{
"characterID": "Character-11",
"name": "Hu Tao",
"rarity": "R"
},
{
"characterID": "Character-33",
"name": "Zhongli",
"rarity": "SR"
},
{
"characterID": "Character-11",
"name": "Hu Tao",
"rarity": "R"
},
{
"characterID": "Character-14",
"name": "Kokomi",
"rarity": "R"
},
{
"characterID": "Character-27",
"name": "Gorou",
"rarity": "R"
},
{
"characterID": "Character-46",
"name": "Xiangling",
"rarity": "R"
},
{
"characterID": "Character-14",
"name": "Kokomi",
"rarity": "R"
},
{
"characterID": "Character-46",
"name": "Xiangling",
"rarity": "R"
},
{
"characterID": "Character-45",
"name": "Barbara",
"rarity": "R"
},
{
"characterID": "Character-7",
"name": "Water Nymph",
"rarity": "R"
},
{
"characterID": "Character-11",
"name": "Hu Tao",
"rarity": "R"
},
{
"characterID": "Character-38",
"name": "Raiden Shogun",
"rarity": "SSR"
},
{
"characterID": "Character-7",
"name": "Water Nymph",
"rarity": "R"
},
{
"characterID": "Character-8",
"name": "Ayaka",
"rarity": "R"
},
{
"characterID": "Character-46",
"name": "Xiangling",
"rarity": "R"
}
]
}

GuiltyMorishita · 2023-06-01T13:18:05Z

I confirm that it has been more efficient.
However, it appears that the user's character is not stored in the database, is that correct?

GuiltyMorishita · 2023-06-01T13:18:26Z

@iamananya The proof is not enough.
The number of times is too small for 20 times, use the data of 10000 times.
You only looked at rarity, right? You also need to check if characters of the same rarity are draw at the same rate.

iamananya · 2023-06-01T13:21:42Z

@iamananya The proof is not enough. The number of times is too small for 20 times, use the data of 10000 times. You only looked at rarity, right? You also need to check if characters of the same rarity are draw at the same rate.

Yes I only checked the rarity. I will show you the proof of 10000 times data as well.
I didn't understand the meaning of character of same rarity are drawn at same rate. Can you please explain @GuiltyMorishita

iamananya · 2023-06-01T13:22:27Z

I confirm that it has been more efficient. However, it appears that the user's character is not stored in the database, is that correct?

Yes they are not stored 🥲.

iamananya · 2023-06-02T04:07:14Z

I confirm that it has been more efficient. However, it appears that the user's character is not stored in the database, is that correct?

I have added in the latest commit @GuiltyMorishita .

GuiltyMorishita · 2023-06-02T05:26:50Z

I didn't understand the meaning of character of same rarity are drawn at same rate. Can you please explain

@iamananya

I think it is the following logic.

There are two S-ranked characters. (Character A, B).
The draw rate of S-ranked characters is 10%.
Therefore, the draw rate of character A is 5%.

Therefore, I want you to prove that each character is drawn according to the assumed probability.
And I want to make sure that it is not the case that only certain characters are draw more.

GuiltyMorishita · 2023-06-02T05:33:37Z

pkg/models/gacha.go

+	return nil
+}
+
+func createBatch(tx *gorm.DB, batch []*UserCharacter) error {


This function name makes it difficult to understand what is being done from the outside.

Okay I will change the function name.

GuiltyMorishita · 2023-06-02T05:37:11Z

pkg/controllers/gacha-controller.go

-		i++
+	}
+	// Batch insert user characters into the database
+	if err := models.CreateUserCharacterBatch(userCharacters); err != nil {


Please name it in a way that makes it clear that you are not creating a batch, but rather creating characters with batch.

Okay I meant create user's character batch hence I named it that way.However I will change it if it doesn't make understandable.

GuiltyMorishita · 2023-06-02T05:39:22Z

pkg/controllers/gacha-controller.go

 		return
 	}
-	characterPool := generateCharacterPool(characters)
+	characterPool := GenerateCharacterPool(characters)


What is the reason for capitalization?

There is no reason, I just liked it that way 😄

@iamananya
In Golang, case has meaning.
You need to look up the Golang specs.

@GuiltyMorishita Since this function is not exported, I will make it lowercase.

iamananya · 2023-06-02T09:39:12Z

@GuiltyMorishita I have added all the changes suggested by you . Since I needed to prove the correctness. and I was getting some vague results in the previous implementation. Hence I have modified the code as well.

changes for multiple gacha also added here

iamananya · 2023-06-08T07:12:38Z

This PR fixes issue #9

iamananya requested a review from GuiltyMorishita June 1, 2023 11:17

iamananya force-pushed the efficieny branch from 977f886 to ffd94db Compare June 1, 2023 11:22

iamananya force-pushed the efficieny branch from 7ff97ec to 84b162e Compare June 2, 2023 04:21

GuiltyMorishita requested changes Jun 2, 2023

View reviewed changes

GuiltyMorishita reviewed Jun 2, 2023

View reviewed changes

iamananya force-pushed the efficieny branch from febc305 to 4ea22f5 Compare June 7, 2023 12:03

iamananya requested a review from GuiltyMorishita June 7, 2023 12:05

changes for multiple gacha also added here

7dad55d

changes for multiple gacha also added here

iamananya force-pushed the efficieny branch from 4ea22f5 to 7dad55d Compare June 7, 2023 12:06

Conversation

iamananya commented Jun 1, 2023

Uh oh!

iamananya commented Jun 1, 2023

Uh oh!

iamananya commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuiltyMorishita commented Jun 1, 2023

Uh oh!

GuiltyMorishita commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamananya commented Jun 1, 2023

Uh oh!

iamananya commented Jun 1, 2023

Uh oh!

iamananya commented Jun 2, 2023

Uh oh!

GuiltyMorishita commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamananya commented Jun 2, 2023

Uh oh!

iamananya commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iamananya commented Jun 1, 2023 •

edited

Loading

GuiltyMorishita commented Jun 1, 2023 •

edited

Loading

GuiltyMorishita commented Jun 2, 2023 •

edited

Loading