IBX-5905: Implemented LoadContent events

[mateuszdebinski]

Question	Answer
JIRA issue	IBX-5905
Type	bug
Target Ibexa version	v4.5
BC breaks	no

PR is currently introducing one of the 3 things needed to solve the problem described in JIRA. Thanks to the content type identifier in ContentInfo, we will be able to decide whether the content type belongs to a taxonomy. If so, it will allow us to verify whether the user has the appropriate permissions. The permissions will be checked by introducing a new Event triggered after the content is loaded.
Work on the fix includes:

1. Adding content type identifier to ContentInfo
2. Creating an event that will be triggered after loading the content
3. Adding verification whether the content belongs to taxonomy and if so, verification of permissions to them

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (main for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ibexa/engineering).

[alongosz]

Looks almost ok, but I have some naming & query building remarks.

Also ideally if we keep only necessary legacy persistence fixtures changes.

We need to either add new integration test or modify existing one which checks properties after creating and/or loading content type to see that it's set.

[alongosz]

Looks ok. Let's make CI green.
Small remarks:

[lserwatka]

Just an thought, would be good to test it on large database to see how this change is performing. @mateuszdebinski I think you have access to large datasets.

[mateuszdebinski]

@lserwatka from what I've verified, there shouldn't be any problems with performance. I checked all SQL queries to which I added a new column and didn't see any changes in performance. I tested on a database that has a size of 43GB before uploading it to the database

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[adamwojs]

@mateuszdebinski Could you please add description to PR explaining how this change is related to linked issue?

[adamwojs]

@mateuszdebinski Rebase is needed here

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[alongosz]

@mateuszdebinski what is the status here? I see CI is failing and it was never sent to QA. At this point it would need to be rebased to 4.6, if still valid.

[mateuszdebinski]

@alongosz There's one more thing missing, I'll take care of it this week and do a rebase to 4.6

[alongosz]

Hi @mateuszdebinski, any updates on this one?

[alongosz]

Seems that you're trying to solve too much at once. The scope here was to add identifier to ContentInfo. Where that new event is used?

[alongosz]

I have a feeling this is here on purpose so you won't forget to implement a pair of events - before event and event.
Any POV @Nattfarinn or @ibexa/php-dev?

[mateuszdebinski]

I didn't add the after event for the loadContent function here, but I will add it if necessary :)

[Nattfarinn]

I would say event layer is complete only if it dispatches Before and After events. Before for pipeline interception and input refinement, After as a reaction and postprocessing.

I would add After event. Thanks @alongosz for catching this 👍 .

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[mateuszdebinski]

@alongosz This PR is part of the solution to the problem and for this, we will need this Event to verify in taxonomy whether the content type points to taxonomy to verify the appropriate permissions. PR for taxonomy will be added soon. First, I wanted to have a completed PR for core (without merge but confirmed that everything is ok)

[alongosz]

This PR is part of the solution to the problem and for this, we will need this Event to verify in taxonomy whether the content type points to taxonomy to verify the appropriate permissions. PR for taxonomy will be added soon. First, I wanted to have a completed PR for core (without merge but confirmed that everything is ok)

@mateuszdebinski in that case the essence of the PR changed. I've changed the title accordingly. If you feel that both of these things (events + content type identifier) are separate, then I'd just extract one of those to separate PR and target one PR on top of another. However ATM for me it's not a requirement.

[mateuszdebinski]

added missing Event to maintain consistency, PR should be ready for full check

[alongosz]

+1 with some remarks:

[Nattfarinn]

Looks good to me. 🤔

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud