-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize fields fix #386
Normalize fields fix #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, only comment is that the test doesn't really verify that it successfully returns a list with two objects for the JSON_LIST arg. I don't really find the parameterized test cases that useful here -- it might be more effective to have two tests: one that checks null input is an empty list, and one that checks that it parses JSON_LIST as Substitutions.
Right. Updated in 06d46fe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
dev
before they can be merged tomaster
)Description
This PR supplements #371 by making
NormalizeFieldTransformation.substitutions
andNormalizeFieldTransformation.capitalizationExceptions
not null if no default substitutions are specified in the configurations (at least an empty list is returned).