Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern name bug fix #586

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Pattern name bug fix #586

merged 4 commits into from
Jan 29, 2024

Conversation

br648
Copy link
Contributor

@br648 br648 commented Jan 16, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

PR to include an updated version of GTS-lib which contains a fix for the pattern name bug.

Related GTFS-Lib PR: ibi-group/gtfs-lib#6

@br648 br648 mentioned this pull request Jan 16, 2024
Merged
5 tasks
@miles-grant-ibigroup
Copy link
Contributor

You might want to merge dev into here! I see some overlap with other branches

@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Jan 26, 2024
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@miles-grant-ibigroup miles-grant-ibigroup merged commit cf8904d into dev Jan 29, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the feature/DT-389-pattern-name-update branch January 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @miles-grant-ibigroup @binh-dam-ibigroup