Notify subscribers of auto publish failure #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FeedVersionController.publishToExternalResource(latestFeedVersion); | ||
| LOG.info("Auto-published feed source {} to external resource.", feedSource.id); | ||
| } else { | ||
| // Notify feed and project subscribed users of failure. | ||
| String message = String.format( |
There was a problem hiding this comment.
This will result in two email notifications being sent (for fetched feed versions only):
- A useful email with the text outlined in this block,
- A more generic email that is already being sent, and that reads: "While attempting to process a new feed version for [feed name], an unrecoverable error was encountered. More details: unknown error". I think we can keep the two, although in some future, it will make sense to propagate the error content from this message to the other one. Thoughts?
There was a problem hiding this comment.
How quickly are MTC expecting an update? I think for now we go with two email notifications.
There was a problem hiding this comment.
We can keep it at two emails for now and iterate based on their feedback.
binh-dam-ibigroup
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Notify subsribers if an auto published feed fails.