Change the logging for socket connection retries #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baemyung
reviewed
Sep 26, 2025
Contributor
baemyung
left a comment
baemyung
left a comment
There was a problem hiding this comment.
It would be also better to show max-count on L153.
L153: BMCWEB_LOG_ERROR("Failed to connect, reached max retry count: {}",
connectRetryCount);
Contributor
|
Could you add some description (e.g. the example output etc) into the commit message? |
Contributor
Author
But in this case, connectRetryCount will be at (or would have reached) maxRetryCount at that time of logging right? |
When connecting to unix socket to offload dump, and if the socket is not ready to accept connections, or for any other reasons, there is a retry mechanism in bmcweb, that tries to connect to the socket for 3 times, before sending back error to the user. This commit improves the logging in case of retries. Tested By: On socket connection retries, the log shows as: ''' Failed to connect, retrying... Retry count: 1 ''' Retries on reaching maxCount (which is 3), the log shows as: ''' Failed to connect, reached max retry count: 3 ''' Signed-off-by: Asmitha Karunanithi <[email protected]>
asmithakarun
force-pushed
the
logChange
branch
from
2f1d150 to
9017e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.