Add support for ReadyToRemove interface #186
Conversation
|
Can one of the admins verify this patch? |
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Seems like more common term would be "inventory item".
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Interface description seems like it is usually termed as "Implement to..."
(this description reads more like the actual property description).
| - name: ReadyToRemove | ||
| type: boolean | ||
| description: > | ||
| An indication of whether the item is prepared by the system for |
There was a problem hiding this comment.
Question: Is this readonly? If not, then I'm wondering about this description. If the property is set to false versus set to true by something?
(The description as written seems to be about what a query of this property would indicate.)
|
add to approvelist |
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
5145d4e to
00ebe9e
Compare
|
Let's give this a week or two upstream before we take it downstream |
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
00ebe9e to
3703bb8
Compare
|
Please add
-- |
This new D-Bus interface is implemented to indicate whether the item is prepared by the system for removal. This property shall indicate whether the system is prepared for the removal of the item. This matches the Redfish ReadyToRemove interface. It will be on other devices. Change-Id: I5c50f8792d968e3427e64ebf99a2fc5f32aaa87a Signed-off-by: Abiola Asojo <[email protected]>
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
3703bb8 to
6c4557e
Compare
|
I would suggest to wait on this until we conclude the Concurrent Maintenance backend design. Is there anything else at bmcweb which needs this dbus interface early? |
Add support for ReadyToRemove interface.