1060: Move Error yaml to VPD directory #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
SunnySrivastava1984
suggested changes
Nov 28, 2023
| errors: | ||
| - xyz.openbmc_project.Common.Error.InvalidArgument | ||
|
|
||
| - name: deleteFRUVPD |
There was a problem hiding this comment.
Why were these removed?
There was a problem hiding this comment.
okay , will check, how this happened.
| - xyz.openbmc_project.Common.Error.InvalidArgument | ||
| - com.ibm.VPD.Error.LocationNotFound | ||
| - com.ibm.VPD.Error.NodeNotFound | ||
| - com.ibm.VPD.VPD.Error.LocationNotFound |
There was a problem hiding this comment.
Lets see if we can rename the file from VPD.errors.yaml.
These repeated VPD.VPD is not looking good and create confusions later on.
There was a problem hiding this comment.
Something like Parser.errors.yaml
There was a problem hiding this comment.
okay, yeah.
but then it will be different from current upstream commit.
This commit is to move yaml/com/ibm/VPD.errors.yaml into yaml/com/ibm/VPD directory Test: Tested the patch on Rainier system. Reached successfully standby - runtime - standby Change-Id: I4e04a865164f7e1a4548ffd7a80b4f035a31573d Signed-off-by: Alpana Kumari <[email protected]>
SunnySrivastava1984
suggested changes
Nov 28, 2023
|
As we discussed, I am closing this PR, as this change is causing lots of other files/components change. We can come back later on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to move yaml/com/ibm/VPD.errors.yaml into yaml/com/ibm/VPD directory
Test:
Tested the patch on Rainier system.
Reached successfully standby - runtime - standby
Change-Id: I4e04a865164f7e1a4548ffd7a80b4f035a31573d