Revert "fix(ScalarFunction): add (currently) required error enum"

This reverts commit 135320b.
icexelloss · Oct 28, 2022 · 3266277 · 3266277
1 parent 45f03d8
commit 3266277
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 17 deletions.
diff --git a/ibis_substrait/compiler/translate.py b/ibis_substrait/compiler/translate.py
@@ -478,27 +478,12 @@ def value_op(
     compiler: SubstraitCompiler,
     **kwargs: Any,
 ) -> stalg.Expression:
-    error_args = []
-    # TODO(gforsyth): remove this brittle workaround after extension parsing is ready
-    # TODO(gforsyth): sending in `ERROR` for floating point ops doesn't match
-    # the substrait spec but is what pyarrow currently expects.
-    if (
-        isinstance(op, ops.BinaryOp)
-        and not isinstance(op, ops.Comparison)
-        and isinstance(op.left.type(), (dt.Integer, dt.Floating))
-        and isinstance(op.right.type(), (dt.Integer, dt.Floating))
-    ):
-        error_args.append(
-            stalg.FunctionArgument(enum=stalg.FunctionArgument.Enum(specified="ERROR"))
-        )
-
     # given the details of `op` -> function id
     return stalg.Expression(
         scalar_function=stalg.Expression.ScalarFunction(
             function_reference=compiler.function_id(expr),
             output_type=translate(expr.type()),
-            arguments=error_args
-            + [
+            arguments=[
                 stalg.FunctionArgument(value=translate(arg, compiler, **kwargs))
                 for arg in op.args
                 if isinstance(arg, ir.Expr)

diff --git a/ibis_substrait/tests/compiler/test_compiler.py b/ibis_substrait/tests/compiler/test_compiler.py
@@ -127,7 +127,6 @@ def test_translate_table_expansion(compiler):
                     "scalarFunction": {
                         "functionReference": 1,
                         "arguments": [
-                            {"enum": {"specified": "ERROR"}},
                             {
                                 "value": {
                                     "selection": {