Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 selecting some calendar dates in dec 2024 jan 2025 unintentionally selects others #142

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aizilerts
Copy link

We changed the valueOf() function in the zotdate file to use built-in function getTime() instead of having values hardcoded in for comparison.

Main (line 59):
/**
* Used for comparing dates with < and >
* @return a number proportional to the amount of days elapsed since 0 AD, although not exact due to leap years
/
valueOf(): number {
return (
this.day.getDate() +
this.day.getMonth() * 31 +
this.day.getFullYear() * 366
);
}
Branch:
/
*
* Used for comparing dates with < and >
* @returns an exact number that refers to the number of milliseconds that have passed since Jan 1, 1970. Can use
* valueOf() to check if the value of two Dates is the same.
*/
valueOf(): number {
const res = this.day.getTime();
return res;
}

seancfong and others added 2 commits January 27, 2025 14:06
* feat: add commitlint for commit messages

* feat: ✨ add devmoji for emoji commits
* Changed page title

* Dynamically pulled meeting name and added it to page title and description

* Added comments
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor fix before we can merge

src/components/creation/calendar/calendar.tsx Outdated Show resolved Hide resolved
…unintentionally-selects-others' of https://github.com/icssc/ZotMeet into 135-selecting-some-calendar-dates-in-dec-2024-jan-2025-unintentionally-selects-others
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm.. the diff looks weird... can we merge main into this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting some calendar dates in Dec 2024 / Jan 2025 unintentionally selects others
6 participants