135 selecting some calendar dates in dec 2024 jan 2025 unintentionally selects others #142
+711
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add commitlint for commit messages * feat: ✨ add devmoji for emoji commits
* Changed page title * Dynamically pulled meeting name and added it to page title and description * Added comments
KevinWu098
requested changes
Feb 3, 2025
…unintentionally-selects-others' of https://github.com/icssc/ZotMeet into 135-selecting-some-calendar-dates-in-dec-2024-jan-2025-unintentionally-selects-others
kylebtran
requested changes
Feb 3, 2025
KevinWu098
requested changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the valueOf() function in the zotdate file to use built-in function getTime() instead of having values hardcoded in for comparison.
Main (line 59):
/**
* Used for comparing dates with < and >
* @return a number proportional to the amount of days elapsed since 0 AD, although not exact due to leap years
/
valueOf(): number {
return (
this.day.getDate() +
this.day.getMonth() * 31 +
this.day.getFullYear() * 366
);
}
Branch:
/*
* Used for comparing dates with < and >
* @returns an exact number that refers to the number of milliseconds that have passed since Jan 1, 1970. Can use
* valueOf() to check if the value of two Dates is the same.
*/
valueOf(): number {
const res = this.day.getTime();
return res;
}