Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting Creation Functionality #102

Merged
merged 9 commits into from
May 20, 2024
Merged

Meeting Creation Functionality #102

merged 9 commits into from
May 20, 2024

Conversation

MinhxNguyen7
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 commented May 20, 2024

Description

  • Add functionality to create meeting according to data in the meeting setup stores.
  • The page redirects based on the id of the created meeting and does not redirect if a meeting ID is not received.
  • Refactor insertMeeting and insertMeetingDates to accept a list of dates (instead of a range provided by start and end times).
  • Change the start and end times to HourMinuteString (HH:MM) from timestamp.
    • There was no reason to use ISO time stamp there. This just makes it clear. It doesn't work with time zones, but our app wouldn't work properly in different time zones anyway.

Test Plan

  • Input requisite data in the meeting creation page.
  • Click create and see that it redirects to the availability page.
  • Verify that the dates in the availability page match up with the ones selected in the creation page.
    • NOTE: The time range won't match up because it's hard-coded to be 8-5:30.
  • Verify that the start and end times are correct in the database.

Issues

Future Follow-Up

  • Display the availability time range according to the start and end times of the meeting in the database (Retrieve availability range from DB instead of hard-coding #103).
  • Verify that everything works between time zones or lock everything to one time zone.
    • I'm of the opinion that the latter is preferred.
  • Add meeting name to availability page.

@MinhxNguyen7 MinhxNguyen7 added the enhancement New feature or request label May 20, 2024
@MinhxNguyen7 MinhxNguyen7 requested a review from seancfong May 20, 2024 06:43
@MinhxNguyen7 MinhxNguyen7 self-assigned this May 20, 2024
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 06:43 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 07:03 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 07:12 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 07:26 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 07:42 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 marked this pull request as ready for review May 20, 2024 07:54
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 08:23 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 08:42 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-102 May 20, 2024 21:52 — with GitHub Actions Inactive
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seancfong seancfong merged commit 47051c6 into main May 20, 2024
1 check passed
@seancfong seancfong deleted the meeting-setup branch May 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Meeting creation page
2 participants