Merge mesh generators#32847
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
a81cd1d to
54e18e2
Compare
|
Job Documentation, step Docs: sync website on e26df14 wanted to post the following: View the site here This comment will be updated on new commits. |
6154931 to
7ec291e
Compare
7ec291e to
54a9631
Compare
54a9631 to
194515e
Compare
194515e to
7340f6a
Compare
7340f6a to
21e0bb2
Compare
74bf3a9 to
cdb7692
Compare
cdb7692 to
651057a
Compare
651057a to
0bdb326
Compare
0bdb326 to
8c71acc
Compare
8c71acc to
0de0af5
Compare
0de0af5 to
fb51b06
Compare
|
Job Precheck on fb51b06 : invalidated by @kyriv1980 |
1 similar comment
|
Job Precheck on fb51b06 : invalidated by @kyriv1980 |
|
Job Non unity build on fb51b06 : invalidated by @kyriv1980 |
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
93f49ee to
c2bfa59
Compare
GiudGiud
left a comment
There was a problem hiding this comment.
This has no backwards compatibility. You're breaking everyone's inputs, at PSU, at Oklo etc. You need to add an info page with what to do to change their inputs to adapt to the new version of MOOSE. Ideally you would leave an action or some deprecated objects behind to give them the link to that page when they try to run their simulation.
You're regolding a very significant share of SCM tests.
To merge two MGs you should have nothing to regold. Just keep the option to have the pin mesh or not in the new MG and the results should not have changed.
And in a follow up PR, you can remove this option if you'd like, thus needing the regold.
The widespread deletion of comments in the code needs to be entirely reversed.
c385e8d to
c276e0b
Compare
|
Job Precheck, step Clang format on e23b90a wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
|
Job Framework 1 on c276e0b : invalidated by @kyriv1980 |
|
Job Coverage on c276e0b : invalidated by @kyriv1980 |
Guard quad and tri assembly mesh generators against invalid axial grids, zero-length domains, and malformed spacer/blockage inputs before mesh construction. Keep quadrilateral assemblies consistent by rejecting only 1x1 layouts while allowing valid 1xN and Nx1 subchannel meshes. Fix triangular assembly block-id fallback handling so the deprecated block_id parameter is still honored when subchannel_block_id is not set. Also add a quad mesh-object guard so pin index lookup on no-pin 1xN/Nx1 meshes reports a clear error instead of evaluating unsigned underflow arithmetic. Add detailed quad coverage for the 1x1 rejection while preserving 1x2 and Nx1 generation behavior. Refs idaholab#32847
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
c276e0b to
5c3b19d
Compare
… tests and v&v cases, Refs idaholab#32796
Unify the triangular subchannel/pin mesh generators behind
SCMTriAssemblyMeshGenerator and SCMDetailedTriAssemblyMeshGenerator,
matching the earlier quad-generator merge and the new convention that
assembly generators build both subchannel and pin meshes when pins
exist.
This updates triangular inputs, tests, and registrations to use the new
assembly generator names directly and removes the old tri alias
registrations for consistency with the quad side.
While validating the merged detailed-tri path, fix several regressions:
- stop mutating TriSubChannelMesh from the detailed visualization generator
- avoid post-build renumbering in the detailed-tri assembly path
- copy _pin_nodes in TriSubChannelMesh copy construction
- assign unique element IDs to generated pin prisms by starting from
mesh_base->n_elem()
Also refresh the detailed triangular mesh test baseline to reflect the
new combined subchannel+pin mesh output and quiet its verbose debug
logging. Refs idaholab#32796
Guard quad and tri assembly mesh generators against invalid axial grids, zero-length domains, and malformed spacer/blockage inputs before mesh construction. Keep quadrilateral assemblies consistent by rejecting only 1x1 layouts while allowing valid 1xN and Nx1 subchannel meshes. Fix triangular assembly block-id fallback handling so the deprecated block_id parameter is still honored when subchannel_block_id is not set. Also add a quad mesh-object guard so pin index lookup on no-pin 1xN/Nx1 meshes reports a clear error instead of evaluating unsigned underflow arithmetic. Add detailed quad coverage for the 1x1 rejection while preserving 1x2 and Nx1 generation behavior. Refs idaholab#32847
Remove unused detailed pin mesh generator code and an unused tri assembly helper. Make quad and tri power IC/Aux objects require a pin mesh and apply q_prime only on pin nodes. Update added-heat calculations to source heat from pin nodes only, returning zero for no-pin meshes. Refresh related power object documentation to match the pin-only behavior. Refs idaholab#32847
Add a migration page for the merged SubChannel mesh generators, including old-to-new object mappings, example input updates, and parameter changes. Link the migration page from the SubChannel landing page and the new assembly mesh generator documentation. Restore explanatory comments in the merged quad/tri mesh generator code where logic was moved from the old subchannel and pin mesh generators.Refs idaholab#32796
8050942 to
e26df14
Compare
|
Job Test, step Results summary on e26df14 wanted to post the following: Framework test summaryCompared against 7282911 in job civet.inl.gov/job/3829583. No change Modules test summaryCompared against 7282911 in job civet.inl.gov/job/3829583. Removed tests
Added tests
Run time changes
|
This PR resolves issue #32796